maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Replace dyn_cast with isa in places that weren't using the returned value for more than a boolean check. NFC. 

llvm-svn: 253441
This commit is contained in:
Craig Topper 2015-11-18 07:07:59 +00:00
parent cd67662ad9
commit 66059c9f4d
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
View File

@ -704,7 +704,7 @@ DWARFContextInMemory::DWARFContextInMemory(const object::ObjectFile &Obj,
// relocation point already factors in the section address
// (actually applying the relocations will produce wrong results
// as the section address will be added twice).
if (!L && dyn_cast<MachOObjectFile>(&Obj))
if (!L && isa<MachOObjectFile>(&Obj))
continue;
RelSecName = RelSecName.substr(

2
llvm/lib/Linker/LinkModules.cpp
View File

@ -664,7 +664,7 @@ bool ModuleLinker::doImportAsDefinition(const GlobalValue *SGV) {
// global variables with external linkage are transformed to
// available_externally definitions, which are ultimately turned into
// declarations after the EliminateAvailableExternally pass).
if (dyn_cast<GlobalVariable>(SGV) && !SGV->isDeclaration() &&
if (isa<GlobalVariable>(SGV) && !SGV->isDeclaration() &&
!SGV->hasWeakAnyLinkage())
return true;
// Only import the function requested for importing.

4
llvm/lib/Target/Hexagon/HexagonISelLowering.cpp
View File

@ -2430,8 +2430,8 @@ bool HexagonTargetLowering::IsEligibleForTailCallOptimization(
// ***************************************************************************
// If this is a tail call via a function pointer, then don't do it!
if (!(dyn_cast<GlobalAddressSDNode>(Callee))
&& !(dyn_cast<ExternalSymbolSDNode>(Callee))) {
if (!(isa<GlobalAddressSDNode>(Callee)) &&
!(isa<ExternalSymbolSDNode>(Callee))) {
return false;
}

4
llvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
View File

@ -985,7 +985,7 @@ public:
bool isRegIdx() const { return Kind == k_RegisterIndex; }
bool isImm() const override { return Kind == k_Immediate; }
bool isConstantImm() const {
return isImm() && dyn_cast<MCConstantExpr>(getImm());
return isImm() && isa<MCConstantExpr>(getImm());
}
bool isConstantImmz() const {
return isConstantImm() && getConstantImm() == 0;
@ -1003,7 +1003,7 @@ public:
}
bool isMem() const override { return Kind == k_Memory; }
bool isConstantMemOff() const {
return isMem() && dyn_cast<MCConstantExpr>(getMemOff());
return isMem() && isa<MCConstantExpr>(getMemOff());
}
template <unsigned Bits> bool isMemWithSimmOffset() const {
return isMem() && isConstantMemOff() && isInt<Bits>(getConstantMemOff())

6
llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp
View File

@ -1214,7 +1214,7 @@ bool SeparateConstOffsetFromGEP::isLegalToSwapOperand(
// Skip constant shift instruction which may be generated by Splitting GEPs.
if (FirstOffsetDef && FirstOffsetDef->isShift() &&
dyn_cast<ConstantInt>(FirstOffsetDef->getOperand(1)))
isa<ConstantInt>(FirstOffsetDef->getOperand(1)))
FirstOffsetDef = dyn_cast<Instruction>(FirstOffsetDef->getOperand(0));
// Give up if FirstOffsetDef is an Add or Sub with constant.
@ -1223,8 +1223,8 @@ bool SeparateConstOffsetFromGEP::isLegalToSwapOperand(
if (BinaryOperator *BO = dyn_cast<BinaryOperator>(FirstOffsetDef)) {
unsigned opc = BO->getOpcode();
if ((opc == Instruction::Add || opc == Instruction::Sub) &&
(dyn_cast<ConstantInt>(BO->getOperand(0)) ||
dyn_cast<ConstantInt>(BO->getOperand(1))))
(isa<ConstantInt>(BO->getOperand(0)) ||
isa<ConstantInt>(BO->getOperand(1))))
return false;
}
return true;