maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Update comment: .note.GNU-stack is added by default today. 

llvm-svn: 295939
This commit is contained in:
Rui Ueyama 2017-02-23 07:15:46 +00:00
parent 0633273d05
commit 65efe35632
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lld/ELF/InputFiles.cpp
View File

@ -418,11 +418,12 @@ elf::ObjectFile<ELFT>::createInputSection(const Elf_Shdr &Sec,
// that the code in the object file does not expect that the stack is
// executable (in terms of NX bit). If all input files have the marker,
// the GNU linker adds a PT_GNU_STACK segment to tells the loader to
// make the stack non-executable.
// make the stack non-executable. Most object files have this section as
// of 2017.
//
// But making the stack non-executable is a norm today for security
// reasons (as of 2017). Failure to do so may result in a serious
// security issue. Therefore, LLD always adds PT_GNU_STACK unless it is
// reasons. Failure to do so may result in a serious security issue.
// Therefore, we make LLD always add PT_GNU_STACK unless it is
// explicitly told to do otherwise (by -z execstack). Because the stack
// executable-ness is controlled solely by command line options,
// .note.GNU-stack sections are simply ignored.