maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

fall back to explicit list of allowed linkages when instrumenting globals in asan; add a test check that asan does not touch linkonce_odr 

llvm-svn: 144933
This commit is contained in:
Kostya Serebryany 2011-11-17 23:14:59 +00:00
parent 040ddfedc0
commit 65e2211b95
2 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp
View File

@ -448,8 +448,11 @@ bool AddressSanitizer::insertGlobalRedzones(Module &M) {
if (!Ty->isSized()) continue;
if (!G->hasInitializer()) continue;
if (GlobalVariable::mayBeOverridden(G->getLinkage()) ||
G->getLinkage() == GlobalVariable::AppendingLinkage)
// Touch only those globals that will not be defined in other modules.
// Don't handle ODR type linkages since other modules may be built w/o asan.
if (G->getLinkage() != GlobalVariable::GlobalVariable::ExternalLinkage &&
G->getLinkage() != GlobalVariable::GlobalVariable::PrivateLinkage &&
G->getLinkage() != GlobalVariable::GlobalVariable::InternalLinkage)
continue;
// For now, just ignore this Alloca if the alignment is large.
if (G->getAlignment() > RedzoneSize) continue;

6
llvm/test/Instrumentation/AddressSanitizer/do-not-touch-odr-global.ll Normal file
View File

@ -0,0 +1,6 @@
; RUN: opt < %s -asan -S | FileCheck %s
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64"
target triple = "x86_64-unknown-linux-gnu"
; no action should be taken for these globals
@v1 = linkonce_odr constant i8 1
; CHECK-NOT: __asan_register_globals