maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[libc] Use '+' constraint on inline assembly 

As suggested by @mcgrathr in D118099

Reviewed By: lntue

Differential Revision: https://reviews.llvm.org/D119978
This commit is contained in:
Alex Brachet 2022-02-17 03:00:17 +00:00
parent dd8490d207
commit 64f5f6d759
3 changed files with 5 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libc/src/math/x86_64/cos.cpp
View File

@ -12,9 +12,8 @@
namespace __llvm_libc {
LLVM_LIBC_FUNCTION(double, cos, (double x)) {
double result;
__asm__ __volatile__("fcos" : "=t"(result) : "f"(x) : "cc");
return result;
__asm__ __volatile__("fcos" : "+t"(x));
return x;
}
} // namespace __llvm_libc

5
libc/src/math/x86_64/sin.cpp
View File

@ -12,9 +12,8 @@
namespace __llvm_libc {
LLVM_LIBC_FUNCTION(double, sin, (double x)) {
double result;
__asm__ __volatile__("fsin" : "=t"(result) : "f"(x) : "cc");
return result;
__asm__ __volatile__("fsin" : "+t"(x));
return x;
}
} // namespace __llvm_libc

3
libc/src/math/x86_64/tan.cpp
View File

@ -13,10 +13,9 @@ namespace __llvm_libc {
LLVM_LIBC_FUNCTION(double, tan, (double x)) {
double result;
double one;
// The fptan instruction pushes the number 1 on to the FP stack after
// computing tan. So, we read out the one before popping the actual result.
__asm__ __volatile__("fptan" : "=t"(one) : "f"(x) : "cc");
__asm__ __volatile__("fptan" : "+t"(x));
__asm__ __volatile__("fstpl %0" : "=m"(result));
return result;
}