maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[ELF] Set `addAbsoluteAtom` and `addUndefinedAtom` functions return type to void 

We do not use values returned by these functions anywhere.
So let's return nothing.

llvm-svn: 234358
This commit is contained in:
Simon Atanasyan 2015-04-07 21:12:28 +00:00
parent 3dba8a2d96
commit 64bcb690e9
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/lib/ReaderWriter/ELF/ELFFile.h
View File

@ -450,7 +450,7 @@ public:
: ELFFile<ELFT>(name, ctx) {}
/// \brief add a global absolute atom
virtual Atom *addAbsoluteAtom(StringRef symbolName) {
virtual void addAbsoluteAtom(StringRef symbolName) {
assert(!symbolName.empty() && "AbsoluteAtoms must have a name");
Elf_Sym *sym = new (this->_readerStorage) Elf_Sym;
sym->st_name = 0;
@ -461,11 +461,10 @@ public:
sym->st_size = 0;
ELFAbsoluteAtom<ELFT> *atom = this->createAbsoluteAtom(symbolName, sym, -1);
this->_absoluteAtoms._atoms.push_back(atom);
return atom;
}
/// \brief add an undefined atom
virtual Atom *addUndefinedAtom(StringRef symbolName) {
virtual void addUndefinedAtom(StringRef symbolName) {
assert(!symbolName.empty() && "UndefinedAtoms must have a name");
Elf_Sym *sym = new (this->_readerStorage) Elf_Sym;
sym->st_name = 0;
@ -476,7 +475,6 @@ public:
sym->st_size = 0;
ELFUndefinedAtom<ELFT> *atom = this->createUndefinedAtom(symbolName, sym);
this->_undefinedAtoms._atoms.push_back(atom);
return atom;
}
// cannot add atoms to Runtime file

2
lld/lib/ReaderWriter/ELF/OutputELFWriter.h
View File

@ -37,7 +37,7 @@ public:
SymbolFile(ELFLinkingContext &ctx)
: RuntimeFile<ELFT>(ctx, "Dynamic absolute symbols") {}
Atom *addUndefinedAtom(StringRef) override {
void addUndefinedAtom(StringRef) override {
llvm_unreachable("Cannot add undefined atoms to resolve undefined symbols");
}