From 63d69a21b7a7c07c0004823fb68a58a439adbc84 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Mon, 16 May 2022 10:09:28 +0000 Subject: [PATCH] Apply clang-tidy fixes for performance-unnecessary-value-param in Utils.cpp (NFC) --- mlir/include/mlir/Dialect/SCF/Utils/Utils.h | 2 +- mlir/lib/Dialect/SCF/Utils/Utils.cpp | 7 ++++--- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/mlir/include/mlir/Dialect/SCF/Utils/Utils.h b/mlir/include/mlir/Dialect/SCF/Utils/Utils.h index 95df92e2edc6..09032cb679a8 100644 --- a/mlir/include/mlir/Dialect/SCF/Utils/Utils.h +++ b/mlir/include/mlir/Dialect/SCF/Utils/Utils.h @@ -54,7 +54,7 @@ using NewYieldValueFn = std::function( OpBuilder &b, Location loc, ArrayRef newBBArgs)>; scf::ForOp replaceLoopWithNewYields(OpBuilder &builder, scf::ForOp loop, ValueRange newIterOperands, - NewYieldValueFn newYieldValuesFn); + const NewYieldValueFn &newYieldValuesFn); /// Outline a region with a single block into a new FuncOp. /// Assumes the FuncOp result types is the type of the yielded operands of the diff --git a/mlir/lib/Dialect/SCF/Utils/Utils.cpp b/mlir/lib/Dialect/SCF/Utils/Utils.cpp index d4c96e51d549..0910cb31f13c 100644 --- a/mlir/lib/Dialect/SCF/Utils/Utils.cpp +++ b/mlir/lib/Dialect/SCF/Utils/Utils.cpp @@ -36,9 +36,10 @@ struct LoopParams { }; } // namespace -scf::ForOp mlir::replaceLoopWithNewYields(OpBuilder &builder, scf::ForOp loop, - ValueRange newIterOperands, - NewYieldValueFn newYieldValuesFn) { +scf::ForOp +mlir::replaceLoopWithNewYields(OpBuilder &builder, scf::ForOp loop, + ValueRange newIterOperands, + const NewYieldValueFn &newYieldValuesFn) { // Create a new loop before the existing one, with the extra operands. OpBuilder::InsertionGuard g(builder); builder.setInsertionPoint(loop);