maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] Remove unnecessary code from ReadabilityModuleTest 

D56303 added testing code that was then made redundant by the changes in D125026. However this code wasn't completely removed in the latter patch.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D130026
This commit is contained in:
Nathan James 2022-07-19 05:21:09 +01:00
parent 8ed702b83f
commit 6357f1c1aa
No known key found for this signature in database
GPG Key ID: CC007AFCDA90AA5F
2 changed files with 0 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
clang-tools-extra/unittests/clang-tidy/CMakeLists.txt
View File

@ -43,7 +43,6 @@ clang_target_link_libraries(ClangTidyTests
clangFrontend
clangLex
clangSerialization
clangTesting
clangTooling
clangToolingCore
clangTransformer

33
clang-tools-extra/unittests/clang-tidy/ReadabilityModuleTest.cpp
View File

@ -1,4 +1,3 @@
#include "../../clang/unittests/ASTMatchers/ASTMatchersTest.h"
#include "ClangTidyTest.h"
#include "readability/BracesAroundStatementsCheck.h"
#include "readability/NamespaceCommentCheck.h"
@ -12,38 +11,6 @@ namespace test {
using readability::BracesAroundStatementsCheck;
using readability::NamespaceCommentCheck;
using readability::SimplifyBooleanExprCheck;
using namespace ast_matchers;
// Copied from ASTMatchersTests
static std::vector<TestClangConfig> allTestClangConfigs() {
std::vector<TestClangConfig> all_configs;
for (TestLanguage lang : {Lang_C89, Lang_C99, Lang_CXX03, Lang_CXX11,
Lang_CXX14, Lang_CXX17, Lang_CXX20}) {
TestClangConfig config;
config.Language = lang;
// Use an unknown-unknown triple so we don't instantiate the full system
// toolchain. On Linux, instantiating the toolchain involves stat'ing
// large portions of /usr/lib, and this slows down not only this test, but
// all other tests, via contention in the kernel.
//
// FIXME: This is a hack to work around the fact that there's no way to do
// the equivalent of runToolOnCodeWithArgs without instantiating a full
// Driver. We should consider having a function, at least for tests, that
// invokes cc1.
config.Target = "i386-unknown-unknown";
all_configs.push_back(config);
// Windows target is interesting to test because it enables
// `-fdelayed-template-parsing`.
config.Target = "x86_64-pc-win32-msvc";
all_configs.push_back(config);
}
return all_configs;
}
INSTANTIATE_TEST_SUITE_P(ASTMatchersTests, ASTMatchersTest,
testing::ValuesIn(allTestClangConfigs()));
TEST(NamespaceCommentCheckTest, Basic) {
EXPECT_EQ("namespace i {\n} // namespace i",