maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SCCP] Improve assert messages. NFCI. 

I've been hitting those already while working on SCCP and I think
it's be useful to provide a more explanatory diagnostic.

llvm-svn: 276007
This commit is contained in:
Davide Italiano 2016-07-19 18:31:07 +00:00
parent 6b08be9279
commit 63266b6be5
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/lib/Transforms/Scalar/SCCP.cpp
View File

@ -301,7 +301,8 @@ public:
}
void markOverdefined(Value *V) {
assert(!V->getType()->isStructTy() && "Should use other method");
assert(!V->getType()->isStructTy() &&
"structs should use markAnythingOverdefined");
markOverdefined(ValueState[V], V);
}
@ -334,12 +335,12 @@ private:
}
void markConstant(Value *V, Constant *C) {
assert(!V->getType()->isStructTy() && "Should use other method");
assert(!V->getType()->isStructTy() && "structs should use mergeInValue");
markConstant(ValueState[V], V, C);
}
void markForcedConstant(Value *V, Constant *C) {
assert(!V->getType()->isStructTy() && "Should use other method");
assert(!V->getType()->isStructTy() && "structs should use mergeInValue");
LatticeVal &IV = ValueState[V];
IV.markForcedConstant(C);
DEBUG(dbgs() << "markForcedConstant: " << *C << ": " << *V << '\n');
@ -374,7 +375,8 @@ private:
}
void mergeInValue(Value *V, LatticeVal MergeWithV) {
assert(!V->getType()->isStructTy() && "Should use other method");
assert(!V->getType()->isStructTy() &&
"non-structs should use markConstant");
mergeInValue(ValueState[V], V, MergeWithV);
}