maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

LTO: rename the various makeLTOModule overloads. 

This rename makes it easier to identify the specific overload being called
in each particular case and makes future refactorings easier.

Differential Revision: http://reviews.llvm.org/D4370

llvm-svn: 212302
This commit is contained in:
Peter Collingbourne 2014-07-03 23:28:00 +00:00
parent 30f37f5fc4
commit 63086fe166
5 changed files with 33 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
llvm/include/llvm/LTO/LTOModule.h
View File

@ -86,16 +86,18 @@ public:
/// InitializeAllTargetMCs();
/// InitializeAllAsmPrinters();
/// InitializeAllAsmParsers();
static LTOModule *makeLTOModule(const char *path, TargetOptions options,
std::string &errMsg);
static LTOModule *makeLTOModule(int fd, const char *path, size_t size,
TargetOptions options, std::string &errMsg);
static LTOModule *makeLTOModule(int fd, const char *path, size_t map_size,
off_t offset, TargetOptions options,
std::string &errMsg);
static LTOModule *makeLTOModule(const void *mem, size_t length,
TargetOptions options, std::string &errMsg,
StringRef path = "");
static LTOModule *createFromFile(const char *path, TargetOptions options,
std::string &errMsg);
static LTOModule *createFromOpenFile(int fd, const char *path, size_t size,
TargetOptions options,
std::string &errMsg);
static LTOModule *createFromOpenFileSlice(int fd, const char *path,
size_t map_size, off_t offset,
TargetOptions options,
std::string &errMsg);
static LTOModule *createFromBuffer(const void *mem, size_t length,
TargetOptions options, std::string &errMsg,
StringRef path = "");
/// Return the Module's target triple.
const char *getTargetTriple() {

29
llvm/lib/LTO/LTOModule.cpp
View File

@ -94,10 +94,8 @@ bool LTOModule::isTargetMatch(MemoryBuffer *buffer, const char *triplePrefix) {
return strncmp(Triple.c_str(), triplePrefix, strlen(triplePrefix)) == 0;
}
/// makeLTOModule - Create an LTOModule. N.B. These methods take ownership of
/// the buffer.
LTOModule *LTOModule::makeLTOModule(const char *path, TargetOptions options,
std::string &errMsg) {
LTOModule *LTOModule::createFromFile(const char *path, TargetOptions options,
std::string &errMsg) {
std::unique_ptr<MemoryBuffer> buffer;
if (std::error_code ec = MemoryBuffer::getFile(path, buffer)) {
errMsg = ec.message();
@ -106,17 +104,16 @@ LTOModule *LTOModule::makeLTOModule(const char *path, TargetOptions options,
return makeLTOModule(std::move(buffer), options, errMsg);
}
LTOModule *LTOModule::makeLTOModule(int fd, const char *path,
size_t size, TargetOptions options,
std::string &errMsg) {
return makeLTOModule(fd, path, size, 0, options, errMsg);
LTOModule *LTOModule::createFromOpenFile(int fd, const char *path, size_t size,
TargetOptions options,
std::string &errMsg) {
return createFromOpenFileSlice(fd, path, size, 0, options, errMsg);
}
LTOModule *LTOModule::makeLTOModule(int fd, const char *path,
size_t map_size,
off_t offset,
TargetOptions options,
std::string &errMsg) {
LTOModule *LTOModule::createFromOpenFileSlice(int fd, const char *path,
size_t map_size, off_t offset,
TargetOptions options,
std::string &errMsg) {
std::unique_ptr<MemoryBuffer> buffer;
if (std::error_code ec =
MemoryBuffer::getOpenFileSlice(fd, path, buffer, map_size, offset)) {
@ -126,9 +123,9 @@ LTOModule *LTOModule::makeLTOModule(int fd, const char *path,
return makeLTOModule(std::move(buffer), options, errMsg);
}
LTOModule *LTOModule::makeLTOModule(const void *mem, size_t length,
TargetOptions options,
std::string &errMsg, StringRef path) {
LTOModule *LTOModule::createFromBuffer(const void *mem, size_t length,
TargetOptions options,
std::string &errMsg, StringRef path) {
std::unique_ptr<MemoryBuffer> buffer(makeBuffer(mem, length, path));
if (!buffer)
return nullptr;

2
llvm/tools/gold/gold-plugin.cpp
View File

@ -292,7 +292,7 @@ static ld_plugin_status claim_file_hook(const ld_plugin_input_file *file,
return LDPS_OK;
std::string Error;
M = LTOModule::makeLTOModule(view, file->filesize, TargetOpts, Error);
M = LTOModule::createFromBuffer(view, file->filesize, TargetOpts, Error);
if (!M) {
(*message)(LDPL_ERROR,
"LLVM gold plugin has failed to create LTO module: %s",

2
llvm/tools/llvm-lto/llvm-lto.cpp
View File

@ -110,7 +110,7 @@ int main(int argc, char **argv) {
for (unsigned i = BaseArg; i < InputFilenames.size(); ++i) {
std::string error;
std::unique_ptr<LTOModule> Module(
LTOModule::makeLTOModule(InputFilenames[i].c_str(), Options, error));
LTOModule::createFromFile(InputFilenames[i].c_str(), Options, error));
if (!error.empty()) {
errs() << argv[0] << ": error loading file '" << InputFilenames[i]
<< "': " << error << "\n";

12
llvm/tools/lto/lto.cpp
View File

@ -104,14 +104,14 @@ lto_module_is_object_file_in_memory_for_target(const void* mem,
lto_module_t lto_module_create(const char* path) {
lto_initialize();
llvm::TargetOptions Options = InitTargetOptionsFromCodeGenFlags();
return wrap(LTOModule::makeLTOModule(path, Options, sLastErrorString));
return wrap(LTOModule::createFromFile(path, Options, sLastErrorString));
}
lto_module_t lto_module_create_from_fd(int fd, const char *path, size_t size) {
lto_initialize();
llvm::TargetOptions Options = InitTargetOptionsFromCodeGenFlags();
return wrap(
LTOModule::makeLTOModule(fd, path, size, Options, sLastErrorString));
LTOModule::createFromOpenFile(fd, path, size, Options, sLastErrorString));
}
lto_module_t lto_module_create_from_fd_at_offset(int fd, const char *path,
@ -120,14 +120,14 @@ lto_module_t lto_module_create_from_fd_at_offset(int fd, const char *path,
off_t offset) {
lto_initialize();
llvm::TargetOptions Options = InitTargetOptionsFromCodeGenFlags();
return wrap(LTOModule::makeLTOModule(fd, path, map_size, offset, Options,
sLastErrorString));
return wrap(LTOModule::createFromOpenFileSlice(fd, path, map_size, offset,
Options, sLastErrorString));
}
lto_module_t lto_module_create_from_memory(const void* mem, size_t length) {
lto_initialize();
llvm::TargetOptions Options = InitTargetOptionsFromCodeGenFlags();
return wrap(LTOModule::makeLTOModule(mem, length, Options, sLastErrorString));
return wrap(LTOModule::createFromBuffer(mem, length, Options, sLastErrorString));
}
lto_module_t lto_module_create_from_memory_with_path(const void* mem,
@ -136,7 +136,7 @@ lto_module_t lto_module_create_from_memory_with_path(const void* mem,
lto_initialize();
llvm::TargetOptions Options = InitTargetOptionsFromCodeGenFlags();
return wrap(
LTOModule::makeLTOModule(mem, length, Options, sLastErrorString, path));
LTOModule::createFromBuffer(mem, length, Options, sLastErrorString, path));
}
void lto_module_dispose(lto_module_t mod) { delete unwrap(mod); }