Check args passed to __builtin_frame_address and __builtin_return_address.

Verifies that an argument passed to __builtin_frame_address or __builtin_return_address is within the range [0, 0xFFFF]

Differential revision: https://reviews.llvm.org/D66839

Re-committed after fixed: c93112dc4f
This commit is contained in:
zoecarver 2020-02-25 12:42:49 -08:00
parent 6d0d1a63f2
commit 6201f6601d
2 changed files with 29 additions and 2 deletions

View File

@ -1847,6 +1847,11 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID,
if (SemaBuiltinOSLogFormat(TheCall)) if (SemaBuiltinOSLogFormat(TheCall))
return ExprError(); return ExprError();
break; break;
case Builtin::BI__builtin_frame_address:
case Builtin::BI__builtin_return_address:
if (SemaBuiltinConstantArgRange(TheCall, 0, 0, 0xFFFF))
return ExprError();
break;
} }
// Since the target specific builtins for each arch overlap, only check those // Since the target specific builtins for each arch overlap, only check those

View File

@ -1,4 +1,5 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s // RUN: %clang_cc1 -fsyntax-only -verify %s
void* a(unsigned x) { void* a(unsigned x) {
return __builtin_return_address(0); return __builtin_return_address(0);
} }
@ -8,9 +9,30 @@ return __builtin_return_address(x); // expected-error{{argument to '__builtin_re
} }
void* c(unsigned x) { void* c(unsigned x) {
// expected-error@+1 {{argument value 4294967295 is outside the valid range [0, 65535]}}
return __builtin_return_address(-1);
}
void* d(unsigned x) {
// expected-error@+1 {{argument value 1048575 is outside the valid range [0, 65535]}}
return __builtin_return_address(0xFFFFF);
}
void* e(unsigned x) {
return __builtin_frame_address(0); return __builtin_frame_address(0);
} }
void d(unsigned x) { void f(unsigned x) {
return __builtin_frame_address(x); // expected-error{{argument to '__builtin_frame_address' must be a constant integer}} // expected-error@+1 {{argument to '__builtin_frame_address' must be a constant integer}}
return __builtin_frame_address(x);
}
void* g(unsigned x) {
// expected-error@+1 {{argument value 4294967295 is outside the valid range [0, 65535]}}
return __builtin_frame_address(-1);
}
void* h(unsigned x) {
// expected-error@+1 {{argument value 1048575 is outside the valid range [0, 65535]}}
return __builtin_frame_address(0xFFFFF);
} }