Do not perform check for missing '[super dealloc]' under ARC as calling -dealloc is illegal in that mode.

llvm-svn: 138261
This commit is contained in:
Ted Kremenek 2011-08-22 19:07:43 +00:00
parent 5765f4c24c
commit 618e574253
2 changed files with 12 additions and 4 deletions

View File

@ -292,7 +292,9 @@ void Sema::ActOnStartOfObjCMethodDef(Scope *FnBodyScope, Decl *D) {
// Finally, in ActOnFinishFunctionBody() (SemaDecl), warn if flag is set.
// Only do this if the current class actually has a superclass.
if (IC->getSuperClass())
ObjCShouldCallSuperDealloc = MDecl->getMethodFamily() == OMF_dealloc;
ObjCShouldCallSuperDealloc =
!Context.getLangOptions().ObjCAutoRefCount &&
MDecl->getMethodFamily() == OMF_dealloc;
}
}

View File

@ -1,5 +1,3 @@
// RUN: %clang_cc1 -fsyntax-only -verify %s
@protocol NSCopying @end
@interface NSObject <NSCopying>
@ -18,7 +16,7 @@
@implementation Subclass1
- (void)dealloc {
} // expected-warning{{method possibly missing a [super dealloc] call}}
}
@end
@interface Subclass2 : NSObject
@ -30,3 +28,11 @@
[super dealloc]; // Shouldn't warn
}
@end
// RUN: %clang_cc1 -fsyntax-only %s 2>&1 | FileCheck %s
// CHECK: warn-missing-super.m:19:1: warning: method possibly missing a [super dealloc] call
// CHECK: 1 warning generated.
// RUN: %clang_cc1 -fsyntax-only -triple x86_64-apple-darwin10 -fobjc-nonfragile-abi -fobjc-arc %s 2>&1 | FileCheck --check-prefix=CHECK-ARC %s
// CHECK-ARC: warn-missing-super.m:28:4: error: ARC forbids explicit message send of 'dealloc'
// CHECK-ARC: 1 error generated.