maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Storing a set of PATypeHolders is a bad idea because their sort order will 

change as types are refined. Remove abstract types from CheckedTypes when they
we're informed that they have been refined. The only way types get refined in
the verifier is when later function passes start optimizing. Fixes PR4970.

llvm-svn: 81716
This commit is contained in:
Nick Lewycky 2009-09-13 21:07:59 +00:00
parent 002f2b3eec
commit 6133026331
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/VMCore/Verifier.cpp
View File

@ -107,7 +107,8 @@ PreVer("preverify", "Preliminary module verification");
static const PassInfo *const PreVerifyID = &PreVer;
namespace {
struct Verifier : public FunctionPass, public InstVisitor<Verifier> {
struct Verifier : public FunctionPass, public InstVisitor<Verifier>,
public AbstractTypeUser {
static char ID; // Pass ID, replacement for typeid
bool Broken; // Is this module found to be broken?
bool RealPass; // Are we not being run by a PassManager?
@ -126,7 +127,7 @@ namespace {
SmallPtrSet<Instruction*, 16> InstsInThisBlock;
/// CheckedTypes - keep track of the types that have been checked already.
SmallSet<PATypeHolder, 16> CheckedTypes;
SmallSet<const Type *, 16> CheckedTypes;
Verifier()
: FunctionPass(&ID),
@ -336,6 +337,13 @@ namespace {
WriteType(T3);
Broken = true;
}
// Abstract type user interface.
void refineAbstractType(const DerivedType *OldTy, const Type *NewTy) {
CheckedTypes.erase(OldTy);
}
void typeBecameConcrete(const DerivedType *AbsTy) {}
void dump() const {}
};
} // End anonymous namespace