From 60b71ce0e4f23e2dd73c58c7c0f15df6702ed188 Mon Sep 17 00:00:00 2001 From: Raphael Isemann Date: Thu, 11 Jul 2019 19:26:55 +0000 Subject: [PATCH] [lldb] Don't use __FUNCTION__ as a file name Summary: I saw while debugging that we call this file `ParseInternal`, which is not a very good name for our fake expression file and also adds this unnecessary link between the way we name this function and the other source location names we get from the expression parser. This patch is renaming it to `` which is closer to the way Clang names its buffers, it doesn't depend on the function name (which changes when I refactor this code) and it's easier to grep for. Reviewers: davide Reviewed By: davide Subscribers: abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D64545 llvm-svn: 365812 --- .../Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp index ec757501c237..a2bc38764f86 100644 --- a/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp +++ b/lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp @@ -920,7 +920,7 @@ ClangExpressionParser::ParseInternal(DiagnosticManager &diagnostic_manager, if (!created_main_file) { std::unique_ptr memory_buffer = - MemoryBuffer::getMemBufferCopy(expr_text, __FUNCTION__); + MemoryBuffer::getMemBufferCopy(expr_text, ""); source_mgr.setMainFileID(source_mgr.createFileID(std::move(memory_buffer))); }