From 5f9bc580d81ba0f8f2c2e8ba4ad13eca07bf1198 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Sun, 13 Jun 2021 10:18:51 -0400 Subject: [PATCH] fix comment typos to cycle bots --- lld/MachO/InputSection.h | 2 +- lld/MachO/SyntheticSections.cpp | 16 ++++++++-------- lld/MachO/Writer.cpp | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/lld/MachO/InputSection.h b/lld/MachO/InputSection.h index dc7b239d554f..fa4292f06e5c 100644 --- a/lld/MachO/InputSection.h +++ b/lld/MachO/InputSection.h @@ -75,7 +75,7 @@ private: }; // ConcatInputSections are combined into (Concat)OutputSections through simple -// concatentation, in contrast with literal sections which may have their +// concatenation, in contrast with literal sections which may have their // contents merged before output. class ConcatInputSection : public InputSection { public: diff --git a/lld/MachO/SyntheticSections.cpp b/lld/MachO/SyntheticSections.cpp index cec0f950fe7e..f402ff6e0b1b 100644 --- a/lld/MachO/SyntheticSections.cpp +++ b/lld/MachO/SyntheticSections.cpp @@ -1099,14 +1099,14 @@ void BitcodeBundleSection::writeTo(uint8_t *buf) const { // that only contains a duplicate cstring at a different alignment. See PR50563 // for details. // -// In practice, the cstrings we've seen so far that require special aligment are -// all accessed by x86_64 SIMD operations -- x86_64 requires SIMD accesses to be -// 16-byte-aligned. So for now, I'm just aligning all strings to 16 bytes on -// x86_64. This is indeed wasteful, but implementation-wise it's simpler than -// preserving per-string alignment+offsets. It also avoids the aforementioned -// crash after deduplication of differently-aligned strings. Finally, the -// overhead is not huge: using 16-byte alignment (vs no alignment) is only a -// 0.5% size overhead when linking chromium_framework. +// In practice, the cstrings we've seen so far that require special alignment +// are all accessed by x86_64 SIMD operations -- x86_64 requires SIMD accesses +// to be 16-byte-aligned. So for now, I'm just aligning all strings to 16 bytes +// on x86_64. This is indeed wasteful, but implementation-wise it's simpler +// than preserving per-string alignment+offsets. It also avoids the +// aforementioned crash after deduplication of differently-aligned strings. +// Finally, the overhead is not huge: using 16-byte alignment (vs no alignment) +// is only a 0.5% size overhead when linking chromium_framework. CStringSection::CStringSection() : SyntheticSection(segment_names::text, section_names::cString), builder(StringTableBuilder::RAW, diff --git a/lld/MachO/Writer.cpp b/lld/MachO/Writer.cpp index 93d6af607209..b5048c463a40 100644 --- a/lld/MachO/Writer.cpp +++ b/lld/MachO/Writer.cpp @@ -715,7 +715,7 @@ template void Writer::createLoadCommands() { // command line and implicitly as a reexport from a different // framework. The re-export will usually point to the tbd file // in Foo.framework/Versions/A/Foo.tbd, while the explicit link will - // usually find Foo.framwork/Foo.tbd. These are usually symlinks, + // usually find Foo.framework/Foo.tbd. These are usually symlinks, // but in a --reproduce archive they will be identical but distinct // files. // In the first case, *semantically distinct* DylibFiles will have the