forked from OSchip/llvm-project
fix comment typos to cycle bots
This commit is contained in:
parent
56541d1377
commit
5f9bc580d8
|
@ -75,7 +75,7 @@ private:
|
|||
};
|
||||
|
||||
// ConcatInputSections are combined into (Concat)OutputSections through simple
|
||||
// concatentation, in contrast with literal sections which may have their
|
||||
// concatenation, in contrast with literal sections which may have their
|
||||
// contents merged before output.
|
||||
class ConcatInputSection : public InputSection {
|
||||
public:
|
||||
|
|
|
@ -1099,14 +1099,14 @@ void BitcodeBundleSection::writeTo(uint8_t *buf) const {
|
|||
// that only contains a duplicate cstring at a different alignment. See PR50563
|
||||
// for details.
|
||||
//
|
||||
// In practice, the cstrings we've seen so far that require special aligment are
|
||||
// all accessed by x86_64 SIMD operations -- x86_64 requires SIMD accesses to be
|
||||
// 16-byte-aligned. So for now, I'm just aligning all strings to 16 bytes on
|
||||
// x86_64. This is indeed wasteful, but implementation-wise it's simpler than
|
||||
// preserving per-string alignment+offsets. It also avoids the aforementioned
|
||||
// crash after deduplication of differently-aligned strings. Finally, the
|
||||
// overhead is not huge: using 16-byte alignment (vs no alignment) is only a
|
||||
// 0.5% size overhead when linking chromium_framework.
|
||||
// In practice, the cstrings we've seen so far that require special alignment
|
||||
// are all accessed by x86_64 SIMD operations -- x86_64 requires SIMD accesses
|
||||
// to be 16-byte-aligned. So for now, I'm just aligning all strings to 16 bytes
|
||||
// on x86_64. This is indeed wasteful, but implementation-wise it's simpler
|
||||
// than preserving per-string alignment+offsets. It also avoids the
|
||||
// aforementioned crash after deduplication of differently-aligned strings.
|
||||
// Finally, the overhead is not huge: using 16-byte alignment (vs no alignment)
|
||||
// is only a 0.5% size overhead when linking chromium_framework.
|
||||
CStringSection::CStringSection()
|
||||
: SyntheticSection(segment_names::text, section_names::cString),
|
||||
builder(StringTableBuilder::RAW,
|
||||
|
|
|
@ -715,7 +715,7 @@ template <class LP> void Writer::createLoadCommands() {
|
|||
// command line and implicitly as a reexport from a different
|
||||
// framework. The re-export will usually point to the tbd file
|
||||
// in Foo.framework/Versions/A/Foo.tbd, while the explicit link will
|
||||
// usually find Foo.framwork/Foo.tbd. These are usually symlinks,
|
||||
// usually find Foo.framework/Foo.tbd. These are usually symlinks,
|
||||
// but in a --reproduce archive they will be identical but distinct
|
||||
// files.
|
||||
// In the first case, *semantically distinct* DylibFiles will have the
|
||||
|
|
Loading…
Reference in New Issue