maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LICM] Avoid duplicate work during building AliasSetTracker 

Currently we re-use cached info from sub loops or traverse them
to populate AliasSetTracker. But after that we traverse all basic blocks
from the current loop. This is redundant work.

All what we need is traversing the all basic blocks from the loop except
those which are used to get the data from the cache.

This should improve compile time only.

Reviewers: mkazantsev, reames, kariddi, anna
Reviewed By: reames
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D51715

llvm-svn: 341896
This commit is contained in:
Serguei Katkov 2018-09-11 04:07:36 +00:00
parent 796b0e7a90
commit 5f4a9e9ea0
1 changed files with 6 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
llvm/lib/Transforms/Scalar/LICM.cpp
View File

@ -1535,11 +1535,6 @@ LoopInvariantCodeMotion::collectAliasInfoForLoop(Loop *L, LoopInfo *LI,
AliasAnalysis *AA) {
std::unique_ptr<AliasSetTracker> CurAST;
SmallVector<Loop *, 4> RecomputeLoops;
auto mergeLoop = [&CurAST](Loop *L) {
// Loop over the body of this loop, looking for calls, invokes, and stores.
for (BasicBlock *BB : L->blocks())
CurAST->add(*BB); // Incorporate the specified basic block
};
for (Loop *InnerL : L->getSubLoops()) {
auto MapI = LoopToAliasSetMap.find(InnerL);
// If the AST for this inner loop is missing it may have been merged into
@ -1566,10 +1561,13 @@ LoopInvariantCodeMotion::collectAliasInfoForLoop(Loop *L, LoopInfo *LI,
// Add everything from the sub loops that are no longer directly available.
for (Loop *InnerL : RecomputeLoops)
mergeLoop(InnerL);
for (BasicBlock *BB : InnerL->blocks())
CurAST->add(*BB);
// And merge in this loop.
mergeLoop(L);
// And merge in this loop (without anything from inner loops).
for (BasicBlock *BB : L->blocks())
if (LI->getLoopFor(BB) == L)
CurAST->add(*BB);
return CurAST;
}