maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

COFF: Fix common symbol alignment. 

llvm-svn: 240217
This commit is contained in:
Rui Ueyama 2015-06-20 07:25:45 +00:00
parent efb7e1aa29
commit 5e31d0b2e9
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lld/COFF/Chunks.cpp
View File

@ -16,6 +16,7 @@
#include "llvm/Support/Debug.h"
#include "llvm/Support/Endian.h"
#include "llvm/Support/raw_ostream.h"
#include <algorithm>
using namespace llvm;
using namespace llvm::object;
@ -169,10 +170,9 @@ SectionRef SectionChunk::getSectionRef() {
}
CommonChunk::CommonChunk(const COFFSymbolRef S) : Sym(S) {
// Alignment is a section attribute, but common symbols don't
// belong to any section. How do we know common data alignments?
// Needs investigating. For now, we set a large number as an alignment.
Align = 16;
// Common symbols are aligned on natural boundaries up to 32 bytes.
// This is what MSVC link.exe does.
Align = std::min(uint64_t(32), NextPowerOf2(Sym.getValue()));
}
uint32_t CommonChunk::getPermissions() const {

4
lld/test/COFF/common.test
View File

@ -4,7 +4,7 @@
# Operands of B8 (MOV EAX) are common symbols
CHECK: 3000: b8 00 10 00 40
CHECK: 3005: b8 10 10 00 40
CHECK: 3005: b8 04 10 00 40
CHECK: 300a: b8 20 10 00 40
CHECK: 300f: b8 60 10 00 40
CHECK: 3014: b8 70 10 00 40
CHECK: 3014: b8 80 10 00 40