sink twine.h down out of Value.h. It is annoying that you need

to #include Twine.h just to give a twine a default value.

llvm-svn: 92247

llvm/include/llvm/Argument.h

@@ -17,6 +17,7 @@
 #include "llvm/Value.h"
 #include "llvm/Attributes.h"
 #include "llvm/ADT/ilist_node.h"
+#include "llvm/ADT/Twine.h"
 
 namespace llvm {
 

llvm/include/llvm/BasicBlock.h

@@ -17,6 +17,7 @@
 #include "llvm/Instruction.h"
 #include "llvm/SymbolTableListTraits.h"
 #include "llvm/ADT/ilist.h"
+#include "llvm/ADT/Twine.h"
 #include "llvm/System/DataTypes.h"
 
 namespace llvm {

llvm/include/llvm/GlobalAlias.h

@@ -18,6 +18,7 @@
 #include "llvm/GlobalValue.h"
 #include "llvm/OperandTraits.h"
 #include "llvm/ADT/ilist_node.h"
+#include "llvm/ADT/Twine.h"
 
 namespace llvm {
 

llvm/include/llvm/GlobalValue.h

@@ -56,7 +56,7 @@ public:
 
 protected:
   GlobalValue(const Type *ty, ValueTy vty, Use *Ops, unsigned NumOps,
-              LinkageTypes linkage, const Twine &Name = "")
+              LinkageTypes linkage, const Twine &Name)
     : Constant(ty, vty, Ops, NumOps), Parent(0),
       Linkage(linkage), Visibility(DefaultVisibility), Alignment(0) {
     setName(Name);

llvm/include/llvm/GlobalVariable.h

@@ -23,6 +23,7 @@
 #include "llvm/GlobalValue.h"
 #include "llvm/OperandTraits.h"
 #include "llvm/ADT/ilist_node.h"
+#include "llvm/ADT/Twine.h"
 
 namespace llvm {
 

llvm/include/llvm/InstrTypes.h

@@ -20,6 +20,7 @@
 #include "llvm/OperandTraits.h"
 #include "llvm/Operator.h"
 #include "llvm/DerivedTypes.h"
+#include "llvm/ADT/Twine.h"
 
 namespace llvm {
 
@@ -160,7 +161,7 @@ public:
   /// Instruction is allowed to be a dereferenced end iterator.
   ///
   static BinaryOperator *Create(BinaryOps Op, Value *S1, Value *S2,
-                                const Twine &Name = "",
+                                const Twine &Name = Twine(),
                                 Instruction *InsertBefore = 0);
 
   /// Create() - Construct a binary instruction, given the opcode and the two

llvm/include/llvm/Value.h

@@ -17,7 +17,6 @@
 #include "llvm/AbstractTypeUser.h"
 #include "llvm/Use.h"
 #include "llvm/ADT/StringRef.h"
-#include "llvm/ADT/Twine.h"
 #include "llvm/Support/Casting.h"
 #include <string>
 
@@ -43,6 +42,7 @@ class AssemblyAnnotationWriter;
 class ValueHandleBase;
 class LLVMContext;
 class MetadataContextImpl;
+class Twine;
 
 //===----------------------------------------------------------------------===//
 //                                 Value Class