maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang-tidy] SimplifyBooleanExprCheck - use cast<> instead of dyn_cast<> to avoid dereference of nullptr 

The IfStmt pointer is always referenced inside the replaceCompoundReturnWithCondition call, so assert the cast is correct instead of returning nullptr
This commit is contained in:
Simon Pilgrim 2022-02-12 19:59:13 +00:00
parent a0e8077d28
commit 5d1e3ed3e2
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang-tools-extra/clang-tidy/readability/SimplifyBooleanExprCheck.cpp
View File

@ -750,7 +750,7 @@ void SimplifyBooleanExprCheck::replaceCompoundReturnWithCondition(
void SimplifyBooleanExprCheck::replaceCaseCompoundReturnWithCondition(
const MatchFinder::MatchResult &Result, bool Negated) {
const auto *CaseDefault = Result.Nodes.getNodeAs<CaseStmt>(CaseId);
const auto *If = dyn_cast<IfStmt>(CaseDefault->getSubStmt());
const auto *If = cast<IfStmt>(CaseDefault->getSubStmt());
replaceCompoundReturnWithCondition(Result, Negated, If);
}
@ -758,14 +758,14 @@ void SimplifyBooleanExprCheck::replaceDefaultCompoundReturnWithCondition(
const MatchFinder::MatchResult &Result, bool Negated) {
const SwitchCase *CaseDefault =
Result.Nodes.getNodeAs<DefaultStmt>(DefaultId);
const auto *If = dyn_cast<IfStmt>(CaseDefault->getSubStmt());
const auto *If = cast<IfStmt>(CaseDefault->getSubStmt());
replaceCompoundReturnWithCondition(Result, Negated, If);
}
void SimplifyBooleanExprCheck::replaceLabelCompoundReturnWithCondition(
const MatchFinder::MatchResult &Result, bool Negated) {
const auto *Label = Result.Nodes.getNodeAs<LabelStmt>(LabelId);
const auto *If = dyn_cast<IfStmt>(Label->getSubStmt());
const auto *If = cast<IfStmt>(Label->getSubStmt());
replaceCompoundReturnWithCondition(Result, Negated, If);
}