maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Remove the string pool from the global destructor chain so it doesn't get yanked out from under us prematurely on exit. 

rdar://problem/11358062

llvm-svn: 156496
This commit is contained in:
Jim Ingham 2012-05-09 18:37:10 +00:00
parent c9bd941f1f
commit 5ce45fdfb1
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lldb/source/Core/ConstString.cpp
View File

@ -167,12 +167,32 @@ protected:
// initializers so we hide the string pool in a static function so
// that it will get initialized on the first call to this static
// function.
//
// Note, for now we make the string pool a pointer to the pool, because
// we can't guarantee that some objects won't get destroyed after the
// global destructor chain is run, and trying to make sure no destructors
// touch ConstStrings is difficult. So we leak the pool instead.
//
// FIXME: If we are going to keep it this way we should come up with some
// abstraction to "pthread_once" so we don't have to check the pointer
// every time.
//----------------------------------------------------------------------
static Pool &
StringPool()
{
static Pool string_pool;
return string_pool;
static Mutex g_pool_initialization_mutex;
static Pool *g_string_pool = NULL;
if (g_string_pool == NULL)
{
Mutex::Locker initialization_locker(g_pool_initialization_mutex);
if (g_string_pool == NULL)
{
g_string_pool = new Pool();
}
}
return *g_string_pool;
}
ConstString::ConstString (const char *cstr) :