maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[LIT] Move display of unsupported and xfail tests to summary. 

Summary:
This patch changes the way xfail and unsupported tests are displayed. 
This output is only displayed when the --show-unsupported/--show-xfail flags are passed to lit.

Currently xfail/unsupported tests are printed during the run of the test-suite. I think its better to display this information during the summary instead.
This patch removes the printing of these tests from when they are run to the summary.


Reviewers: ddunbar, EricWF

Reviewed By: EricWF

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D4842

llvm-svn: 215809
This commit is contained in:
Eric Fiselier 2014-08-16 02:16:25 +00:00
parent 12be8efc62
commit 5ccd9e029f
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
llvm/utils/lit/lit/main.py
View File

@ -43,8 +43,6 @@ class TestingProgressDisplay(object):
test.getFullName()) test.getFullName())
shouldShow = test.result.code.isFailure or \ shouldShow = test.result.code.isFailure or \
(self.opts.show_unsupported and test.result.code.name == 'UNSUPPORTED') or \
(self.opts.show_xfail and test.result.code.name == 'XFAIL') or \
(not self.opts.quiet and not self.opts.succinct) (not self.opts.quiet and not self.opts.succinct)
if not shouldShow: if not shouldShow:
return return
@ -391,7 +389,12 @@ def main(builtinParameters = {}):
# Print each test in any of the failing groups. # Print each test in any of the failing groups.
for title,code in (('Unexpected Passing Tests', lit.Test.XPASS), for title,code in (('Unexpected Passing Tests', lit.Test.XPASS),
('Failing Tests', lit.Test.FAIL), ('Failing Tests', lit.Test.FAIL),
('Unresolved Tests', lit.Test.UNRESOLVED)): ('Unresolved Tests', lit.Test.UNRESOLVED),
('Unsupported Tests', lit.Test.UNSUPPORTED),
('Expected Failing Tests', lit.Test.XFAIL)):
if (lit.Test.XFAIL == code and not opts.show_xfail) or \
(lit.Test.UNSUPPORTED == code and not opts.show_unsupported):
continue
elts = byCode.get(code) elts = byCode.get(code)
if not elts: if not elts:
continue continue
@ -412,7 +415,7 @@ def main(builtinParameters = {}):
('Unsupported Tests ', lit.Test.UNSUPPORTED), ('Unsupported Tests ', lit.Test.UNSUPPORTED),
('Unresolved Tests ', lit.Test.UNRESOLVED), ('Unresolved Tests ', lit.Test.UNRESOLVED),
('Unexpected Passes ', lit.Test.XPASS), ('Unexpected Passes ', lit.Test.XPASS),
('Unexpected Failures', lit.Test.FAIL),): ('Unexpected Failures', lit.Test.FAIL)):
if opts.quiet and not code.isFailure: if opts.quiet and not code.isFailure:
continue continue
N = len(byCode.get(code,[])) N = len(byCode.get(code,[]))