diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index 2cddac5f6674..556665483e64 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -2581,7 +2581,11 @@ void AnalyzeComparison(Sema &S, BinaryOperator *E) { // We don't do anything special if this isn't an unsigned integral // comparison: we're only interested in integral comparisons, and // signed comparisons only happen in cases we don't care to warn about. - if (!T->hasUnsignedIntegerRepresentation()) + // + // We also don't care about value-dependent expressions or expressions + // whose result is a constant. + if (!T->hasUnsignedIntegerRepresentation() + || E->isValueDependent() || E->isIntegerConstantExpr(S.Context)) return AnalyzeImpConvsInComparison(S, E); Expr *lex = E->getLHS()->IgnoreParenImpCasts(); diff --git a/clang/test/SemaCXX/compare.cpp b/clang/test/SemaCXX/compare.cpp index ebecc0633eda..ca8af2186f74 100644 --- a/clang/test/SemaCXX/compare.cpp +++ b/clang/test/SemaCXX/compare.cpp @@ -206,3 +206,9 @@ void test2(int i, void *vp) { if (vp < 0) { } if (test1 < e) { } // expected-error{{comparison between pointer and integer}} } + +// PR7536 +static const unsigned int kMax = 0; +int pr7536() { + return (kMax > 0); +} diff --git a/clang/test/SemaCXX/type-dependent-exprs.cpp b/clang/test/SemaCXX/type-dependent-exprs.cpp index 37d7cee88161..398c3cb0339b 100644 --- a/clang/test/SemaCXX/type-dependent-exprs.cpp +++ b/clang/test/SemaCXX/type-dependent-exprs.cpp @@ -26,10 +26,10 @@ T f(T x) { // This one entered into an infinite loop. template void rdar8520617() { - if (N > 1) { } // expected-warning {{comparison of 0 > unsigned expression is always false}} + if (N > 1) { } } int f2() { - rdar8520617<0>(); // expected-note {{in instantiation}} + rdar8520617<0>(); }