maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PassManager] Tuning Memory Usage of AnalysisUsage 

We were using unneccessarily large initial sizes for these SmallVectors.  This was wasting around 50kb of memory for the O3 pipeline, even after the uniquing changes.  We're still using around 20kb which is a bit much, but it's definitely better.  This is about a 6% improvement in total O3 memory usage.

Note: The raw data on structure size which were used to pick these thresholds can be found in the review thread.

Differential Revision: http://reviews.llvm.org/D15244

llvm-svn: 254974
This commit is contained in:
Philip Reames 2015-12-08 00:10:56 +00:00
parent 3f5d2bc0bc
commit 5ae3418ffe
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/include/llvm/PassAnalysisSupport.h
View File

@ -36,11 +36,17 @@ namespace llvm {
/// ///
class AnalysisUsage { class AnalysisUsage {
public: public:
typedef SmallVector<AnalysisID, 32> VectorType; typedef SmallVectorImpl<AnalysisID> VectorType;
private: private:
/// Sets of analyses required and preserved by a pass /// Sets of analyses required and preserved by a pass
VectorType Required, RequiredTransitive, Preserved, Used; // TODO: It's not clear that SmallVector is an appropriate data structure for
// this usecase. The sizes were picked to minimize wasted space, but are
// otherwise fairly meaningless.
SmallVector<AnalysisID, 8> Required;
SmallVector<AnalysisID, 2> RequiredTransitive;
SmallVector<AnalysisID, 2> Preserved;
SmallVector<AnalysisID, 0> Used;
bool PreservesAll; bool PreservesAll;
public: public: