maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

GlobalISel: Verify atomic load/store ordering restriction 

Reject acquire stores and release loads. This matches the restriction
imposed by the LLParser and IR verifier.
This commit is contained in:
Matt Arsenault 2022-04-10 10:47:12 -04:00
parent 7e8ff962b3
commit 5a5034d508
4 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
llvm/lib/CodeGen/MachineVerifier.cpp
View File

@ -1073,6 +1073,18 @@ void MachineVerifier::verifyPreISelGenericInstruction(const MachineInstr *MI) {
if (ValTy.getSizeInBytes() < MMO.getSize())
report("store memory size cannot exceed value size", MI);
}
const AtomicOrdering Order = MMO.getSuccessOrdering();
if (Opc == TargetOpcode::G_STORE) {
if (Order == AtomicOrdering::Acquire ||
Order == AtomicOrdering::AcquireRelease)
report("atomic store cannot use acquire ordering", MI);
} else {
if (Order == AtomicOrdering::Release ||
Order == AtomicOrdering::AcquireRelease)
report("atomic load cannot use release ordering", MI);
}
}
break;

6
llvm/test/CodeGen/MIR/AArch64/atomic-memoperands.mir
View File

@ -12,15 +12,17 @@ body: |
; CHECK-NEXT: [[LOAD1:%[0-9]+]]:_(s32) = G_LOAD [[COPY]](p0) :: (load monotonic (s32))
; CHECK-NEXT: [[LOAD2:%[0-9]+]]:_(s16) = G_LOAD [[COPY]](p0) :: (load acquire (s16))
; CHECK-NEXT: G_STORE [[LOAD2]](s16), [[COPY]](p0) :: (store release (s16))
; CHECK-NEXT: G_STORE [[LOAD1]](s32), [[COPY]](p0) :: (store acq_rel (s32))
; CHECK-NEXT: G_STORE [[LOAD]](s64), [[COPY]](p0) :: (store syncscope("singlethread") seq_cst (s64))
; CHECK-NEXT: [[ATOMICRMW_ADD:%[0-9]+]]:_(s64) = G_ATOMICRMW_ADD [[COPY]](p0), [[LOAD]] :: (load store acq_rel (s64))
; CHECK-NEXT: [[ATOMICRMW_ADD1:%[0-9]+]]:_(s64) = G_ATOMICRMW_ADD [[COPY]](p0), [[LOAD]] :: (load store seq_cst (s64))
; CHECK-NEXT: RET_ReallyLR
%0:_(p0) = COPY $x0
%1:_(s64) = G_LOAD %0(p0) :: (load unordered (s64))
%2:_(s32) = G_LOAD %0(p0) :: (load monotonic (s32))
%3:_(s16) = G_LOAD %0(p0) :: (load acquire (s16))
G_STORE %3(s16), %0(p0) :: (store release (s16))
G_STORE %2(s32), %0(p0) :: (store acq_rel (s32))
G_STORE %1(s64), %0(p0) :: (store syncscope("singlethread") seq_cst (s64))
%4:_(s64) = G_ATOMICRMW_ADD %0, %1 :: (load store acq_rel (s64))
%5:_(s64) = G_ATOMICRMW_ADD %0, %1 :: (load store seq_cst (s64))
RET_ReallyLR
...

6
llvm/test/MachineVerifier/test_g_load.mir
View File

@ -20,4 +20,10 @@ body: |
; CHECK: Bad machine code: load memory size cannot exceed result size
%3:_(s8) = G_LOAD %2 :: (load (s16))
; CHECK: Bad machine code: atomic load cannot use release ordering
%4:_(s32) = G_LOAD %2 :: (load release (s32))
; CHECK: Bad machine code: atomic load cannot use release ordering
%5:_(s32) = G_LOAD %2 :: (load acq_rel (s32))
...

6
llvm/test/MachineVerifier/test_g_store.mir
View File

@ -21,4 +21,10 @@ body: |
; CHECK: Bad machine code: store memory size cannot exceed value size
G_STORE %3, %2 :: (store (s16))
; CHECK: Bad machine code: atomic store cannot use acquire ordering
G_STORE %1, %2 :: (store acquire (s32))
; CHECK: Bad machine code: atomic store cannot use acquire ordering
G_STORE %1, %2 :: (store acq_rel (s32))
...