maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Remove 4 FIXME's from the CAST patch now that the back end is correctly 

producing code for "trunc to bool". This passes all tests on Linux.

llvm-svn: 31963
This commit is contained in:
Reid Spencer 2006-11-28 07:23:01 +00:00
parent d077fe70e9
commit 59fe2d89ae
1 changed files with 3 additions and 46 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

49
llvm/lib/Transforms/Scalar/InstructionCombining.cpp
View File

@ -5739,13 +5739,6 @@ Instruction *InstCombiner::commonIntCastTransforms(CastInst &CI) {
unsigned SrcBitSize = SrcTy->getPrimitiveSizeInBits();
unsigned DestBitSize = DestTy->getPrimitiveSizeInBits();
// FIXME. We currently implement cast-to-bool as a setne %X, 0. This is
// because codegen cannot accurately perform a truncate to bool operation.
// Something goes wrong in promotion to a larger type. When CodeGen can
// handle a proper truncation to bool, this should be removed.
if (DestTy == Type::BoolTy)
return BinaryOperator::createSetNE(Src, Constant::getNullValue(SrcTy));
// See if we can simplify any instructions used by the LHS whose sole
// purpose is to compute bits we don't care about.
uint64_t KnownZero = 0, KnownOne = 0;
@ -6021,35 +6014,11 @@ Instruction *InstCombiner::visitFPExt(CastInst &CI) {
}
Instruction *InstCombiner::visitFPToUI(CastInst &CI) {
if (Instruction *I = commonCastTransforms(CI))
return I;
// FIXME. We currently implement cast-to-bool as a setne %X, 0. This is
// because codegen cannot accurately perform a truncate to bool operation.
// Something goes wrong in promotion to a larger type. When CodeGen can
// handle a proper truncation to bool, this should be removed.
Value *Src = CI.getOperand(0);
const Type *SrcTy = Src->getType();
const Type *DestTy = CI.getType();
if (DestTy == Type::BoolTy)
return BinaryOperator::createSetNE(Src, Constant::getNullValue(SrcTy));
return 0;
return commonCastTransforms(CI);
}
Instruction *InstCombiner::visitFPToSI(CastInst &CI) {
if (Instruction *I = commonCastTransforms(CI))
return I;
// FIXME. We currently implement cast-to-bool as a setne %X, 0. This is
// because codegen cannot accurately perform a truncate to bool operation.
// Something goes wrong in promotion to a larger type. When CodeGen can
// handle a proper truncation to bool, this should be removed.
Value *Src = CI.getOperand(0);
const Type *SrcTy = Src->getType();
const Type *DestTy = CI.getType();
if (DestTy == Type::BoolTy)
return BinaryOperator::createSetNE(Src, Constant::getNullValue(SrcTy));
return 0;
return commonCastTransforms(CI);
}
Instruction *InstCombiner::visitUIToFP(CastInst &CI) {
@ -6061,19 +6030,7 @@ Instruction *InstCombiner::visitSIToFP(CastInst &CI) {
}
Instruction *InstCombiner::visitPtrToInt(CastInst &CI) {
if (Instruction *I = commonCastTransforms(CI))
return I;
// FIXME. We currently implement cast-to-bool as a setne %X, 0. This is
// because codegen cannot accurately perform a truncate to bool operation.
// Something goes wrong in promotion to a larger type. When CodeGen can
// handle a proper truncation to bool, this should be removed.
Value *Src = CI.getOperand(0);
const Type *SrcTy = Src->getType();
const Type *DestTy = CI.getType();
if (DestTy == Type::BoolTy)
return BinaryOperator::createSetNE(Src, Constant::getNullValue(SrcTy));
return 0;
return commonCastTransforms(CI);
}
Instruction *InstCombiner::visitIntToPtr(CastInst &CI) {