maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Misuse of hasExternalLinkage(), should be checking isDeclaration(). 

llvm-svn: 37419
This commit is contained in:
Evan Cheng 2007-06-04 18:54:57 +00:00
parent 38b6b22a41
commit 59ca6a846f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/Target/X86/X86ATTAsmPrinter.cpp
View File

@ -286,7 +286,7 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo,
}
if (printStub(TM, Subtarget)) {
// Link-once, External, or Weakly-linked global variables need
// Link-once, declaration, or Weakly-linked global variables need
// non-lazily-resolved stubs
if (GV->isDeclaration() ||
GV->hasWeakLinkage() ||
@ -351,7 +351,7 @@ void X86ATTAsmPrinter::printOperand(const MachineInstr *MI, unsigned OpNo,
else
O << "@GOTOFF";
} else if (Subtarget->isPICStyleRIPRel() && !NotRIPRel) {
if ((GV->hasExternalLinkage() ||
if ((GV->isDeclaration() ||
GV->hasWeakLinkage() ||
GV->hasLinkOnceLinkage()) &&
TM.getRelocationModel() != Reloc::Static)