maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

It was pointed out to me that an offset of 0 makes sense for ObjC, but not always for C++, and this API claims to be general enough that it should not drop C++ usability on the floor for no good reason. Fix it with an explicit offset argument 

llvm-svn: 216487
This commit is contained in:
Enrico Granata 2014-08-26 21:35:30 +00:00
parent ca7b0aaa36
commit 59953f0dbe
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lldb/include/lldb/Core/ValueObject.h
View File

@ -677,8 +677,8 @@ public:
GetSyntheticChildAtOffset(uint32_t offset, const ClangASTType& type, bool can_create);
virtual lldb::ValueObjectSP
GetSyntheticBase (const ClangASTType& type, bool can_create);
GetSyntheticBase (uint32_t offset, const ClangASTType& type, bool can_create);
virtual lldb::ValueObjectSP
GetDynamicValue (lldb::DynamicValueType valueType);

3
lldb/source/Core/ValueObject.cpp
View File

@ -2216,7 +2216,7 @@ ValueObject::GetSyntheticChildAtOffset(uint32_t offset, const ClangASTType& type
}
ValueObjectSP
ValueObject::GetSyntheticBase (const ClangASTType& type, bool can_create)
ValueObject::GetSyntheticBase (uint32_t offset, const ClangASTType& type, bool can_create)
{
ValueObjectSP synthetic_child_sp;
@ -2234,7 +2234,6 @@ ValueObject::GetSyntheticBase (const ClangASTType& type, bool can_create)
if (!can_create)
return ValueObjectSP();
const uint32_t offset = 0;
const bool is_base_class = true;
ValueObjectChild *synthetic_child = new ValueObjectChild(*this,