forked from OSchip/llvm-project
Allow -profile-guided-section-prefix more than once
Summary: At present, `-profile-guided-section-prefix` is a `cl::Optional` option, which means it demands to be passed exactly zero or one times. Our build system makes it pretty tricky to guarantee this. We often accidentally pass the flag more than once (but always with the same "false" value) which results in an error, after which compilation fails: ``` clang (LLVM option parsing): for the -profile-guided-section-prefix option: may only occur zero or one times! ``` While we work on improving our build system, it also seems reasonable just to allow `-profile-guided-section-prefix` to be passed more than once, by to `cl::ZeroOrMore`. Quoting [[ http://llvm.org/docs/CommandLine.html#controlling-the-number-of-occurrences-required-and-allowed | the documentation ]]: > The cl::ZeroOrMore modifier ... indicates that your program will allow the option to be specified zero or more times. > ... > If an option is specified multiple times for an option of the cl::opt class, only the last value will be retained. Reviewers: danielcdh Reviewed By: danielcdh Subscribers: twoh, david2050, llvm-commits Differential Revision: https://reviews.llvm.org/D34219 llvm-svn: 305413
This commit is contained in:
parent
a207f6476b
commit
5960d9b1c3
|
@ -134,7 +134,7 @@ static cl::opt<bool> DisablePreheaderProtect(
|
|||
cl::desc("Disable protection against removing loop preheaders"));
|
||||
|
||||
static cl::opt<bool> ProfileGuidedSectionPrefix(
|
||||
"profile-guided-section-prefix", cl::Hidden, cl::init(true),
|
||||
"profile-guided-section-prefix", cl::Hidden, cl::init(true), cl::ZeroOrMore,
|
||||
cl::desc("Use profile info to add section prefix for hot/cold functions"));
|
||||
|
||||
static cl::opt<unsigned> FreqRatioToSkipMerge(
|
||||
|
|
Loading…
Reference in New Issue