maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

PR19562: Fix memory leak when ObjC interface types cause the creation of further interfaces. 

llvm-svn: 208161
This commit is contained in:
David Blaikie 2014-05-07 06:18:00 +00:00
parent aa6dd5bbb0
commit 5944d9ce3e
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/CodeGen/CGDebugInfo.cpp
View File

@ -3332,11 +3332,15 @@ void CGDebugInfo::finalize() {
Ty.replaceAllUsesWith(CGM.getLLVMContext(), RepTy); Ty.replaceAllUsesWith(CGM.getLLVMContext(), RepTy);
} }
for (auto E : ObjCInterfaceCache) // Creating types might create further types - invalidating the current
// element and the size(), so don't cache/reference them.
for (size_t i = 0; i != ObjCInterfaceCache.size(); ++i) {
ObjCInterfaceCacheEntry E = ObjCInterfaceCache[i];
E.Decl.replaceAllUsesWith(CGM.getLLVMContext(), E.Decl.replaceAllUsesWith(CGM.getLLVMContext(),
E.Type->getDecl()->getDefinition() E.Type->getDecl()->getDefinition()
? CreateTypeDefinition(E.Type, E.Unit) ? CreateTypeDefinition(E.Type, E.Unit)
: E.Decl); : E.Decl);
}
// We keep our own list of retained types, because we need to look // We keep our own list of retained types, because we need to look
// up the final type in the type cache. // up the final type in the type cache.