maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

-Bsymbolic should not make symbols more preemptable. 

But it was doing that for protected undefined symbols.

llvm-svn: 274803
This commit is contained in:
Rafael Espindola 2016-07-07 22:50:54 +00:00
parent 3e3652aef2
commit 580d7a1b1e
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lld/ELF/Symbols.cpp
View File

@ -129,11 +129,14 @@ bool SymbolBody::isPreemptible() const {
if (!symbol()->includeInDynsym()) if (!symbol()->includeInDynsym())
return false; return false;
// Normally only default visibility symbols can be preempted, but -Bsymbolic // Only default visibility symbols can be preempted.
// means that not even they can be preempted. if (symbol()->Visibility != STV_DEFAULT)
return false;
// -Bsymbolic means that definitions are not preempted.
if (Config->Bsymbolic || (Config->BsymbolicFunctions && isFunc())) if (Config->Bsymbolic || (Config->BsymbolicFunctions && isFunc()))
return !isDefined(); return !isDefined();
return symbol()->Visibility == STV_DEFAULT; return true;
} }
template <class ELFT> InputFile *SymbolBody::getSourceFile() { template <class ELFT> InputFile *SymbolBody::getSourceFile() {

4
lld/test/ELF/bsymbolic.s
View File

@ -28,3 +28,7 @@ nop
do: do:
callq foo@PLT callq foo@PLT
callq bar@PLT callq bar@PLT
.weak zed
.protected zed
.quad zed