maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Revert r340552, "Driver: Enable address-significance tables by default when targeting COFF." 

Received multiple reports of breakage due to undefined symbols
suspected to be caused by this change.

llvm-svn: 340579
This commit is contained in:
Peter Collingbourne 2018-08-23 21:34:57 +00:00
parent 40b832ea08
commit 577cfb0b5e
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/lib/Driver/ToolChains/Clang.cpp
View File

@ -4857,8 +4857,7 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA,
}
if (Args.hasFlag(options::OPT_faddrsig, options::OPT_fno_addrsig,
(getToolChain().getTriple().isOSBinFormatELF() ||
getToolChain().getTriple().isOSBinFormatCOFF()) &&
getToolChain().getTriple().isOSBinFormatELF() &&
getToolChain().useIntegratedAs()))
CmdArgs.push_back("-faddrsig");

1
clang/test/Driver/addrsig.c
View File

@ -1,5 +1,4 @@
// RUN: %clang -### -target x86_64-unknown-linux -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
// RUN: %clang -### -target x86_64-pc-win32 -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
// RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s
// RUN: %clang -### -target x86_64-unknown-linux -fno-integrated-as -faddrsig -c %s 2>&1 | FileCheck -check-prefix=ADDRSIG %s
// RUN: %clang -### -target x86_64-unknown-linux -fno-addrsig -c %s 2>&1 | FileCheck -check-prefix=NO-ADDRSIG %s