Revert "[lldb-mi] Add overload method for setting an error"

Summary: This reverts commit r334245 because it duplicates
functionality of Status::AsCString used in SBError.

Reviewers: aprantl, clayborg

Reviewed By: clayborg

Subscribers: lldb-commits, ki.stfu

Differential Revision: https://reviews.llvm.org/D48212

llvm-svn: 334860

lldb/tools/lldb-mi/MICmdBase.cpp

@@ -212,23 +212,6 @@ void CMICmdBase::SetError(const CMIUtilString &rErrMsg) {
   m_cmdData.strMiCmdResultRecord = miResultRecord.GetString();
 }
 
-//++
-//------------------------------------------------------------------------------------
-// Details: Short cut function to enter error information into the command's
-//          metadata object and set the command's error status.
-// Type:    Method.
-// Args:    error - (R) Command result description.
-// Return:  None.
-// Throws:  None.
-//--
-void CMICmdBase::SetError(const lldb::SBError &error) {
-  const char *error_cstr = error.GetCString();
-  if (error_cstr)
-    SetError(error_cstr);
-  else
-    SetError("unknown error");
-}
-
 //++
 //------------------------------------------------------------------------------------
 // Details: Ask a command to provide its unique identifier.

lldb/tools/lldb-mi/MICmdBase.h

@@ -12,8 +12,6 @@
 // C Includes
 // C++ Includes
 // Other libraries and framework includes
-#include "lldb/API/SBError.h"
-
 // Project includes
 #include "MICmdArgSet.h"
 #include "MICmdData.h"
@@ -82,7 +80,6 @@ public:
   // Methods:
 protected:
   void SetError(const CMIUtilString &rErrMsg);
-  void SetError(const lldb::SBError &error);
   template <class T> T *GetOption(const CMIUtilString &vStrOptionName);
   bool ParseValidateCmdOptions();