[HWASan] Remove -Wa,-mrelax-relocations=no flag.

We no longer need it after https://reviews.llvm.org/D113220.

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D113221
This commit is contained in:
Matt Morehouse 2021-11-22 10:32:28 -08:00
parent 944071eca2
commit 5684a614dd
2 changed files with 4 additions and 7 deletions

View File

@ -5,6 +5,10 @@
// RUN: not %run %t -1 2>&1 | FileCheck --check-prefixes=CHECK,LSYM %s
// RUN: not %env_hwasan_opts=symbolize=0 %run %t -1 2>&1 | FileCheck --check-prefixes=CHECK,LNOSYM %s
// Test with LTO, since it invokes the integrated assembler separately.
// RUN: %clang_hwasan -flto %s -o %t
// RUN: not %run %t 1 2>&1 | FileCheck --check-prefixes=CHECK,RSYM %s
// Test with and without optimizations, with and without PIC, since different
// backend passes run depending on these flags.
// RUN: %clang_hwasan -fno-pic %s -o %t

View File

@ -18,13 +18,6 @@ if config.target_arch == 'x86_64' and config.enable_aliases == '1':
else:
config.available_features.add('pointer-tagging')
if config.target_arch == 'x86_64':
# By default the assembler uses R_X86_64_REX_GOTPCRELX relocations, which can
# be relaxed to direct references. When tagged globals are enabled, these
# references fail to link since they have more than a 32-bit offset from RIP.
# As a workaround, we disable the relaxation.
# TODO: Implement a way to disable for the affected relocations only.
clang_hwasan_common_cflags += ["-Wa,-mrelax-relocations=no"]
# The callback instrumentation used on x86_64 has a 1/64 chance of choosing a
# stack tag of 0. This causes stack tests to become flaky, so we force tags
# to be generated via calls to __hwasan_generate_tag, which never returns 0.