From 54f5d859ad811e7c765865a358bad1ac401cb08a Mon Sep 17 00:00:00 2001 From: David Blaikie Date: Fri, 10 Feb 2012 05:15:16 +0000 Subject: [PATCH] Move -Wswitch from -Wmost to -Wall, consitent with GCC. This is a relatively noisy warning for a codebase not explicitly designed for it (effectively enforcing a stylistic constraint about the use of defaults in switches over enums) & there's nothing Clang does to clean up the noise when compared to GCC's implementation so the same decision seems suitable. llvm-svn: 150230 --- clang/include/clang/Basic/DiagnosticGroups.td | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/clang/include/clang/Basic/DiagnosticGroups.td b/clang/include/clang/Basic/DiagnosticGroups.td index 1a733d28e0f8..4fa19826b9be 100644 --- a/clang/include/clang/Basic/DiagnosticGroups.td +++ b/clang/include/clang/Basic/DiagnosticGroups.td @@ -317,7 +317,6 @@ def Most : DiagGroup<"most", [ Reorder, ReturnType, SelfAssignment, - Switch, SizeofArrayArgument, Trigraphs, Uninitialized, @@ -331,8 +330,8 @@ def Most : DiagGroup<"most", [ // Thread Safety warnings def ThreadSafety : DiagGroup<"thread-safety">; -// -Wall is -Wmost -Wparentheses -Wdangling-else -def : DiagGroup<"all", [DanglingElse, Most, Parentheses]>; +// -Wall is -Wmost -Wparentheses -Wdangling-else -Wswitch +def : DiagGroup<"all", [DanglingElse, Most, Parentheses, Switch]>; // Aliases. def : DiagGroup<"", [Extra]>; // -W = -Wextra