maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[NVPTX] Error out if initializer is given for variable in an address space that does not support initialization 

llvm-svn: 211943
This commit is contained in:
Justin Holewinski 2014-06-27 18:36:01 +00:00
parent 773ca40f5d
commit 549c773619
2 changed files with 23 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
View File

@ -1502,14 +1502,25 @@ void NVPTXAsmPrinter::printModuleLevelGV(const GlobalVariable *GVar,
// Ptx allows variable initilization only for constant and global state // Ptx allows variable initilization only for constant and global state
// spaces. // spaces.
if (((PTy->getAddressSpace() == llvm::ADDRESS_SPACE_GLOBAL) || if (GVar->hasInitializer()) {
(PTy->getAddressSpace() == llvm::ADDRESS_SPACE_CONST)) && if ((PTy->getAddressSpace() == llvm::ADDRESS_SPACE_GLOBAL) ||
GVar->hasInitializer()) { (PTy->getAddressSpace() == llvm::ADDRESS_SPACE_CONST)) {
const Constant *Initializer = GVar->getInitializer(); const Constant *Initializer = GVar->getInitializer();
if (!Initializer->isNullValue()) { // 'undef' is treated as there is no value spefied.
if (!Initializer->isNullValue() && !isa<UndefValue>(Initializer)) {
O << " = "; O << " = ";
printScalarConstant(Initializer, O); printScalarConstant(Initializer, O);
} }
} else {
// The frontend adds zero-initializer to variables that don't have an
// initial value, so skip warning for this case.
if (!GVar->getInitializer()->isNullValue()) {
std::string warnMsg = "initial value of '" + GVar->getName().str() +
"' is not allowed in addrspace(" +
llvm::utostr_32(PTy->getAddressSpace()) + ")";
report_fatal_error(warnMsg.c_str());
}
}
} }
} else { } else {
unsigned int ElementSize = 0; unsigned int ElementSize = 0;

5
llvm/test/CodeGen/NVPTX/gvar-init.ll Normal file
View File

@ -0,0 +1,5 @@
; RUN: llc < %s -march=nvptx -mcpu=sm_20 | FileCheck %s
; Error out if initializer is given for address spaces that do not support initializers
; XFAIL: *
@g0 = addrspace(3) global i32 42