maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix ASAN failure in memref-dataflow-opt 

- memrefsToErase had duplicates inserted into it; switch to SmallPtrSet.

PiperOrigin-RevId: 227299306
This commit is contained in:
Uday Bondhugula 2018-12-30 12:51:17 -08:00 committed by jpienaar
parent dfee0a6e9b
commit 545f3ce430
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
mlir/lib/Transforms/MemRefDataFlowOpt.cpp
View File

@ -28,7 +28,7 @@
#include "mlir/Pass.h"
#include "mlir/StandardOps/StandardOps.h"
#include "mlir/Transforms/Passes.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/ADT/SmallPtrSet.h"
#include <algorithm>
#define DEBUG_TYPE "memref-dataflow-opt"
@ -72,7 +72,7 @@ struct MemRefDataFlowOpt : public FunctionPass, InstWalker<MemRefDataFlowOpt> {
void visitOperationInst(OperationInst *opInst);
// A list of memref's that are potentially dead / could be eliminated.
std::vector<Value *> memrefsToErase;
SmallPtrSet<Value *, 4> memrefsToErase;
static char passID;
};
@ -199,7 +199,7 @@ void MemRefDataFlowOpt::visitOperationInst(OperationInst *opInst) {
Value *storeVal = lastWriteStoreOp->cast<StoreOp>()->getValueToStore();
loadOp->getResult()->replaceAllUsesWith(storeVal);
// Record the memref for a later sweep to optimize away.
memrefsToErase.push_back(loadOp->getMemRef());
memrefsToErase.insert(loadOp->getMemRef());
loadOp->erase();
}