maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Extract BinaryContext::registerFragment 

Summary: registerFragment to be reused in adding fragments reachable only through jump tables.

(cherry picked from FBD24656651)
This commit is contained in:
Amir Ayupov 2020-11-06 10:27:33 -08:00 committed by Maksim Panchenko
parent 58460460d9
commit 5452287710
2 changed files with 26 additions and 17 deletions

39
bolt/src/BinaryContext.cpp
View File

@ -1018,6 +1018,27 @@ void BinaryContext::generateSymbolHashes() {
}
}
void BinaryContext::registerFragment(BinaryFunction &TargetFunction,
BinaryFunction &Function) const {
// Only a parent function (or a sibling) can reach its fragment.
assert(!Function.IsFragment &&
"only one cold fragment is supported at this time");
if (auto *TargetParent = TargetFunction.getParentFragment()) {
assert(TargetParent == &Function && "mismatching parent function");
return;
}
TargetFunction.setParentFragment(Function);
Function.addFragment(TargetFunction);
if (!HasRelocations) {
TargetFunction.setSimple(false);
Function.setSimple(false);
}
if (opts::Verbosity >= 1) {
outs() << "BOLT-INFO: marking " << TargetFunction
<< " as a fragment of " << Function << '\n';
}
}
void BinaryContext::processInterproceduralReferences(BinaryFunction &Function) {
for (auto Address : Function.InterproceduralReferences) {
if (!Address)
@ -1029,23 +1050,7 @@ void BinaryContext::processInterproceduralReferences(BinaryFunction &Function) {
if (TargetFunction) {
if (TargetFunction->IsFragment) {
// Only a parent function (or a sibling) can reach its fragment.
assert(!Function.IsFragment &&
"only one cold fragment is supported at this time");
if (auto *TargetParent = TargetFunction->getParentFragment()) {
assert(TargetParent == &Function && "mismatching parent function");
continue;
}
TargetFunction->setParentFragment(Function);
Function.addFragment(*TargetFunction);
if (!HasRelocations) {
TargetFunction->setSimple(false);
Function.setSimple(false);
}
if (opts::Verbosity >= 1) {
outs() << "BOLT-INFO: marking " << *TargetFunction
<< " as a fragment of " << Function << '\n';
}
registerFragment(*TargetFunction, Function);
} else if (TargetFunction->getAddress() != Address) {
TargetFunction->
addEntryPointAtOffset(Address - TargetFunction->getAddress());

4
bolt/src/BinaryContext.h
View File

@ -814,6 +814,10 @@ public:
/// @}
/// Register \p TargetFunction as fragment of \p Function.
void registerFragment(BinaryFunction &TargetFunction,
BinaryFunction &Function) const;
/// Resolve inter-procedural dependencies from \p Function.
void processInterproceduralReferences(BinaryFunction &Function);