maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[clang][Interp][NFC] Use constexpr if in OffsetHelper 

Add is a template parameter, so we can use constexpr if here.
This commit is contained in:
Timm Bäder 2022-09-11 14:39:52 +02:00
parent b02f6890f5
commit 53d8687a13
1 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
clang/lib/AST/Interp/Interp.h
View File

@ -788,18 +788,24 @@ template <class T, bool Add> bool OffsetHelper(InterpState &S, CodePtr OpPC) {
return false;
};
// If the new offset would be negative, bail out.
if (Add && Offset.isNegative() && (Offset.isMin() || -Offset > Index))
return InvalidOffset();
if (!Add && Offset.isPositive() && Index < Offset)
return InvalidOffset();
// If the new offset would be out of bounds, bail out.
unsigned MaxOffset = MaxIndex - Ptr.getIndex();
if (Add && Offset.isPositive() && Offset > MaxOffset)
return InvalidOffset();
if (!Add && Offset.isNegative() && (Offset.isMin() || -Offset > MaxOffset))
return InvalidOffset();
if constexpr (Add) {
// If the new offset would be negative, bail out.
if (Offset.isNegative() && (Offset.isMin() || -Offset > Index))
return InvalidOffset();
// If the new offset would be out of bounds, bail out.
if (Offset.isPositive() && Offset > MaxOffset)
return InvalidOffset();
} else {
// If the new offset would be negative, bail out.
if (Offset.isPositive() && Index < Offset)
return InvalidOffset();
// If the new offset would be out of bounds, bail out.
if (Offset.isNegative() && (Offset.isMin() || -Offset > MaxOffset))
return InvalidOffset();
}
// Offset is valid - compute it on unsigned.
int64_t WideIndex = static_cast<int64_t>(Index);