forked from OSchip/llvm-project
Fix branch folding bug for indirect branches: for a block containing only
an unconditional branch (possibly from tail merging), this code is trying to redirect all of its predecessors to go directly to the branch target, but that isn't feasible for indirect branches. The other predecessors (that don't end with indirect branches) could theoretically still be handled, but that is not easily done right now. The AnalyzeBranch interface doesn't currently let us distinguish jump table branches from indirect branches, and this code is currently handling jump tables. To avoid punting on address-taken blocks, we would have to give up handling jump tables. That seems like a bad tradeoff. llvm-svn: 85975
This commit is contained in:
parent
156b8c7109
commit
53a31ad3c1
|
@ -1050,7 +1050,8 @@ bool BranchFolder::OptimizeBlock(MachineBasicBlock *MBB) {
|
|||
// If this branch is the only thing in its block, see if we can forward
|
||||
// other blocks across it.
|
||||
if (CurTBB && CurCond.empty() && CurFBB == 0 &&
|
||||
MBB->begin()->getDesc().isBranch() && CurTBB != MBB) {
|
||||
MBB->begin()->getDesc().isBranch() && CurTBB != MBB &&
|
||||
!MBB->hasAddressTaken()) {
|
||||
// This block may contain just an unconditional branch. Because there can
|
||||
// be 'non-branch terminators' in the block, try removing the branch and
|
||||
// then seeing if the block is empty.
|
||||
|
|
Loading…
Reference in New Issue