maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PowerPC] Fix the incorrect 'RM' flag set on load/store instr 

The 'RM' flag model the "Rounding Mode" and it has nothing to do with the load/store instructions.

Differential Revision: https://reviews.llvm.org/D69551
This commit is contained in:
QingShan Zhang 2019-11-06 02:46:37 +00:00
parent 34688fafea
commit 529bb8a980
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Target/PowerPC/PPCInstrVSX.td
View File

@ -152,7 +152,6 @@ def HasOnlySwappingMemOps : Predicate<"!PPCSubTarget->hasP9Vector()">;
let Predicates = [HasVSX] in { let Predicates = [HasVSX] in {
let AddedComplexity = 400 in { // Prefer VSX patterns over non-VSX patterns. let AddedComplexity = 400 in { // Prefer VSX patterns over non-VSX patterns.
let hasSideEffects = 0 in { // VSX instructions don't have side effects. let hasSideEffects = 0 in { // VSX instructions don't have side effects.
let Uses = [RM] in {
// Load indexed instructions // Load indexed instructions
let mayLoad = 1, mayStore = 0 in { let mayLoad = 1, mayStore = 0 in {
@ -214,6 +213,7 @@ let Uses = [RM] in {
} }
} // mayStore } // mayStore
let Uses = [RM] in {
// Add/Mul Instructions // Add/Mul Instructions
let isCommutable = 1 in { let isCommutable = 1 in {
def XSADDDP : XX3Form<60, 32, def XSADDDP : XX3Form<60, 32,

9
llvm/test/CodeGen/PowerPC/instr-properties.ll Normal file
View File

@ -0,0 +1,9 @@
; RUN: llc < %s -mtriple=powerpc64le-unknown-linux-gnu -mcpu=pwr8 -verify-misched -stop-after=machine-scheduler -o - | FileCheck %s --check-prefix=CHECK-P8
; Verify XFLOADf64 didn't implict def 'rm'.
define double @rm() {
; CHECK-P8-LABEL: bb.0.entry
; CHECK-P8: %{{[0-9]+}}:vsfrc = XFLOADf64 $zero8, %{{[0-9]+}} ::
entry:
ret double 2.300000e+00
}