maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Correctly handle the when we the 'G' packet fails. There were 

cases where we were returning no error even though this packet
was failing.

llvm-svn: 139981
This commit is contained in:
Greg Clayton 2011-09-17 05:47:55 +00:00
parent 9163c394d9
commit 5299cc58cb
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lldb/tools/debugserver/source/RNBRemote.cpp
View File

@ -2480,7 +2480,8 @@ RNBRemote::HandlePacket_G (const char *p)
std::vector<uint8_t> reg_ctx; std::vector<uint8_t> reg_ctx;
reg_ctx.resize(reg_ctx_size); reg_ctx.resize(reg_ctx_size);
if (packet.GetHexBytes (&reg_ctx[0], reg_ctx.size(), 0xcc) == reg_ctx.size()) const nub_size_t bytes_extracted = packet.GetHexBytes (&reg_ctx[0], reg_ctx.size(), 0xcc);
if (bytes_extracted == reg_ctx.size())
{ {
// Now write the register context // Now write the register context
reg_ctx_size = DNBThreadSetRegisterContext(pid, tid, reg_ctx.data(), reg_ctx.size()); reg_ctx_size = DNBThreadSetRegisterContext(pid, tid, reg_ctx.data(), reg_ctx.size());
@ -2489,7 +2490,14 @@ RNBRemote::HandlePacket_G (const char *p)
else else
return SendPacket ("E55"); return SendPacket ("E55");
} }
else
{
DNBLogError("RNBRemote::HandlePacket_G(%s): extracted %zu of %zu bytes, size mismatch\n", p, bytes_extracted, reg_ctx_size);
return SendPacket ("E64");
}
} }
else
return SendPacket ("E65");
} }