maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[PowerPC] Don't use a vector preferred memory type at -O0 

Even at -O0, we fall back to SDAG when we hit intrinsics, and if the intrinsic
is a memset/memcpy/etc. we might normally use vector types. At -O0, this is
probably not a good idea (because, if there is a bug in the lowering code,
there would be no good way to turn it off). At -O0, only use scalar preferred
types.

Related to PR22754.

llvm-svn: 233755
This commit is contained in:
Hal Finkel 2015-03-31 20:56:09 +00:00
parent 1988ac60a6
commit 52368d4437
2 changed files with 25 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
llvm/lib/Target/PowerPC/PPCISelLowering.cpp
View File

@ -11023,21 +11023,23 @@ EVT PPCTargetLowering::getOptimalMemOpType(uint64_t Size,
bool IsMemset, bool ZeroMemset, bool IsMemset, bool ZeroMemset,
bool MemcpyStrSrc, bool MemcpyStrSrc,
MachineFunction &MF) const { MachineFunction &MF) const {
const Function *F = MF.getFunction(); if (getTargetMachine().getOptLevel() != CodeGenOpt::None) {
// When expanding a memset, require at least two QPX instructions to cover const Function *F = MF.getFunction();
// the cost of loading the value to be stored from the constant pool. // When expanding a memset, require at least two QPX instructions to cover
if (Subtarget.hasQPX() && Size >= 32 && (!IsMemset || Size >= 64) && // the cost of loading the value to be stored from the constant pool.
(!SrcAlign || SrcAlign >= 32) && (!DstAlign || DstAlign >= 32) && if (Subtarget.hasQPX() && Size >= 32 && (!IsMemset || Size >= 64) &&
!F->hasFnAttribute(Attribute::NoImplicitFloat)) { (!SrcAlign || SrcAlign >= 32) && (!DstAlign || DstAlign >= 32) &&
return MVT::v4f64; !F->hasFnAttribute(Attribute::NoImplicitFloat)) {
} return MVT::v4f64;
}
// We should use Altivec/VSX loads and stores when available. For unaligned // We should use Altivec/VSX loads and stores when available. For unaligned
// addresses, unaligned VSX loads are only fast starting with the P8. // addresses, unaligned VSX loads are only fast starting with the P8.
if (Subtarget.hasAltivec() && Size >= 16 && if (Subtarget.hasAltivec() && Size >= 16 &&
(((!SrcAlign || SrcAlign >= 16) && (!DstAlign || DstAlign >= 16)) || (((!SrcAlign || SrcAlign >= 16) && (!DstAlign || DstAlign >= 16)) ||
((IsMemset && Subtarget.hasVSX()) || Subtarget.hasP8Vector()))) ((IsMemset && Subtarget.hasVSX()) || Subtarget.hasP8Vector())))
return MVT::v4i32; return MVT::v4i32;
}
if (Subtarget.isPPC64()) { if (Subtarget.isPPC64()) {
return MVT::i64; return MVT::i64;

9
llvm/test/CodeGen/PowerPC/memset-nc.ll
View File

@ -1,4 +1,5 @@
; RUN: llc < %s | FileCheck %s ; RUN: llc < %s | FileCheck %s
; RUN: llc -O0 < %s | FileCheck %s -check-prefix=CHECK-O0
target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64" target datalayout = "E-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f128:128:128-v128:128:128-n32:64"
target triple = "powerpc64-bgq-linux" target triple = "powerpc64-bgq-linux"
@ -14,6 +15,10 @@ entry:
; CHECK: qvstfdx ; CHECK: qvstfdx
; CHECK: qvstfdx ; CHECK: qvstfdx
; CHECK: blr ; CHECK: blr
; CHECK-O0-LABEL: @test_qpx
; CHECK-O0-NOT: qvstfdx
; CHECK-O0: blr
} }
; Function Attrs: nounwind ; Function Attrs: nounwind
@ -31,6 +36,10 @@ entry:
; CHECK: stxvw4x ; CHECK: stxvw4x
; CHECK: stxvw4x ; CHECK: stxvw4x
; CHECK: blr ; CHECK: blr
; CHECK-O0-LABEL: @test_vsx
; CHECK-O0-NOT: stxvw4x
; CHECK-O0: blr
} }
attributes #0 = { nounwind "target-cpu"="a2q" } attributes #0 = { nounwind "target-cpu"="a2q" }