maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[NFC][llvm-dwarfdump] Don't calculate unnecessary stats 

Small optimization of the code -- No need to calculate any stats
for NULL nodes, and also no need to call the collectStatsForDie()
if it is the CU itself.

Differential Revision: https://reviews.llvm.org/D96871
This commit is contained in:
Djordje Todorovic 2021-02-21 23:20:37 -08:00 committed by Djordje Todorovic
parent 97184ab99c
commit 52113451fb
1 changed files with 15 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
llvm/tools/llvm-dwarfdump/Statistics.cpp
View File

@ -227,6 +227,11 @@ static void collectStatsForDie(DWARFDie Die, std::string FnPrefix,
GlobalStats &GlobalStats, GlobalStats &GlobalStats,
LocationStats &LocStats, LocationStats &LocStats,
InlinedVarsTy *InlinedVariables) { InlinedVarsTy *InlinedVariables) {
const dwarf::Tag Tag = Die.getTag();
// Skip CU node.
if (Tag == dwarf::DW_TAG_compile_unit)
return;
bool HasLoc = false; bool HasLoc = false;
bool HasSrcLoc = false; bool HasSrcLoc = false;
bool HasType = false; bool HasType = false;
@ -234,23 +239,22 @@ static void collectStatsForDie(DWARFDie Die, std::string FnPrefix,
uint64_t ScopeBytesCovered = 0; uint64_t ScopeBytesCovered = 0;
uint64_t BytesEntryValuesCovered = 0; uint64_t BytesEntryValuesCovered = 0;
auto &FnStats = FnStatMap[FnPrefix]; auto &FnStats = FnStatMap[FnPrefix];
bool IsParam = Die.getTag() == dwarf::DW_TAG_formal_parameter; bool IsParam = Tag == dwarf::DW_TAG_formal_parameter;
bool IsLocalVar = Die.getTag() == dwarf::DW_TAG_variable; bool IsLocalVar = Tag == dwarf::DW_TAG_variable;
bool IsConstantMember = Die.getTag() == dwarf::DW_TAG_member && bool IsConstantMember = Tag == dwarf::DW_TAG_member &&
Die.find(dwarf::DW_AT_const_value); Die.find(dwarf::DW_AT_const_value);
// For zero covered inlined variables the locstats will be // For zero covered inlined variables the locstats will be
// calculated later. // calculated later.
bool DeferLocStats = false; bool DeferLocStats = false;
if (Die.getTag() == dwarf::DW_TAG_call_site || if (Tag == dwarf::DW_TAG_call_site || Tag == dwarf::DW_TAG_GNU_call_site) {
Die.getTag() == dwarf::DW_TAG_GNU_call_site) {
GlobalStats.CallSiteDIEs++; GlobalStats.CallSiteDIEs++;
return; return;
} }
if (Die.getTag() == dwarf::DW_TAG_call_site_parameter || if (Tag == dwarf::DW_TAG_call_site_parameter ||
Die.getTag() == dwarf::DW_TAG_GNU_call_site_parameter) { Tag == dwarf::DW_TAG_GNU_call_site_parameter) {
GlobalStats.CallSiteParamDIEs++; GlobalStats.CallSiteParamDIEs++;
return; return;
} }
@ -448,6 +452,10 @@ static void collectStatsRecursive(DWARFDie Die, std::string FnPrefix,
InlinedVarsTyMap &GlobalInlinedFnInfo, InlinedVarsTyMap &GlobalInlinedFnInfo,
InlinedFnInstacesTy &InlinedFnsToBeProcessed, InlinedFnInstacesTy &InlinedFnsToBeProcessed,
InlinedVarsTy *InlinedVarsPtr = nullptr) { InlinedVarsTy *InlinedVarsPtr = nullptr) {
// Skip NULL nodes.
if (Die.isNULL())
return;
const dwarf::Tag Tag = Die.getTag(); const dwarf::Tag Tag = Die.getTag();
// Skip function types. // Skip function types.
if (Tag == dwarf::DW_TAG_subroutine_type) if (Tag == dwarf::DW_TAG_subroutine_type)