maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

TypedRegion is a too general assumption. Usually we only want to invalidate 

the VarRegion as a super region of an ElementRegion.

llvm-svn: 71431
This commit is contained in:
Zhongxing Xu 2009-05-11 14:28:14 +00:00
parent c012656266
commit 52091db11f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clang/lib/Analysis/CFRefCount.cpp
View File

@ -2660,7 +2660,7 @@ void CFRefCount::EvalSummary(ExplodedNodeSet<GRState>& Dst,
if (R) {
// Are we dealing with an ElementRegion? If the element type is
// a basic integer type (e.g., char, int) and the underying region
// is also typed then strip off the ElementRegion.
// is a variable region then strip off the ElementRegion.
// FIXME: We really need to think about this for the general case
// as sometimes we are reasoning about arrays and other times
// about (char*), etc., is just a form of passing raw bytes.
@ -2674,8 +2674,8 @@ void CFRefCount::EvalSummary(ExplodedNodeSet<GRState>& Dst,
// still allowing us to do checker-specific logic (e.g.,
// invalidating reference counts), probably via callbacks.
if (ER->getElementType()->isIntegralType())
if (const TypedRegion *superReg =
dyn_cast<TypedRegion>(ER->getSuperRegion()))
if (const VarRegion *superReg =
dyn_cast<VarRegion>(ER->getSuperRegion()))
R = superReg;
// FIXME: What about layers of ElementRegions?
}