[clangd] Support new/deleta operator in TargetFinder.

Differential Revision: https://reviews.llvm.org/D85028
This commit is contained in:
Haojian Wu 2020-07-25 21:52:33 +02:00
parent 21fa82d5c6
commit 5191f70ab1
3 changed files with 41 additions and 0 deletions

View File

@ -460,6 +460,12 @@ public:
void VisitPseudoObjectExpr(const PseudoObjectExpr *POE) {
Outer.add(POE->getSyntacticForm(), Flags);
}
void VisitCXXNewExpr(const CXXNewExpr *CNE) {
Outer.add(CNE->getOperatorNew(), Flags);
}
void VisitCXXDeleteExpr(const CXXDeleteExpr *CDE) {
Outer.add(CDE->getOperatorDelete(), Flags);
}
};
Visitor(*this, Flags).Visit(S);
}

View File

@ -238,6 +238,10 @@ locateASTReferent(SourceLocation CurLoc, const syntax::Token *TouchedIdentifier,
llvm::DenseMap<SymbolID, size_t> ResultIndex;
auto AddResultDecl = [&](const NamedDecl *D) {
// FIXME: Canonical declarations of some symbols might refer to built-in
// decls with possibly-invalid source locations (e.g. global new operator).
// In such cases we should pick up a redecl with valid source location
// instead of failing.
D = llvm::cast<NamedDecl>(D->getCanonicalDecl());
auto Loc =
makeLocation(AST.getASTContext(), nameLocation(*D, SM), MainFilePath);

View File

@ -535,6 +535,7 @@ TEST_F(TargetDeclTest, OverloadExpr) {
// FIXME: Auto-completion in a template requires disabling delayed template
// parsing.
Flags = {"-fno-delayed-template-parsing"};
Flags.push_back("--target=x86_64-pc-linux-gnu");
Code = R"cpp(
void func(int*);
@ -559,6 +560,36 @@ TEST_F(TargetDeclTest, OverloadExpr) {
};
)cpp";
EXPECT_DECLS("UnresolvedMemberExpr", "void func(int *)", "void func(char *)");
Code = R"cpp(
struct X {
static void *operator new(unsigned long);
};
auto* k = [[new]] X();
)cpp";
EXPECT_DECLS("CXXNewExpr", "static void *operator new(unsigned long)");
Code = R"cpp(
void *operator new(unsigned long);
auto* k = [[new]] int();
)cpp";
EXPECT_DECLS("CXXNewExpr", "void *operator new(unsigned long)");
Code = R"cpp(
struct X {
static void operator delete(void *) noexcept;
};
void k(X* x) {
[[delete]] x;
}
)cpp";
EXPECT_DECLS("CXXDeleteExpr", "static void operator delete(void *) noexcept");
Code = R"cpp(
void operator delete(void *) noexcept;
void k(int* x) {
[[delete]] x;
}
)cpp";
EXPECT_DECLS("CXXDeleteExpr", "void operator delete(void *) noexcept");
}
TEST_F(TargetDeclTest, DependentExprs) {