maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix path completion test case added in rL335905 on Windows 

Summary:
The test fails because we don't rewrite the slash behind `foo` to the OS specific
separator (as the completion API doesn't support this kind of rewriting). However,
we assume that this part of the string is rewritten in the test case, which broke
on Windows.

Reviewers: stella.stamenova

Reviewed By: stella.stamenova

Subscribers: lldb-commits

Differential Revision: https://reviews.llvm.org/D48746

llvm-svn: 335934
This commit is contained in:
Raphael Isemann 2018-06-28 22:40:10 +00:00
parent 71dc39823c
commit 517c22041e
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lldb/unittests/Interpreter/TestCompletion.cpp
View File

@ -286,14 +286,12 @@ TEST_F(CompletionTest, DirCompletionUsername) {
Count = CommandCompletions::DiskDirectories("~/foo/", Results, Resolver);
ASSERT_EQ(1u, Count);
ASSERT_EQ(Count, Results.GetSize());
EXPECT_TRUE(ContainsExactString(Twine("~/foo") + path::get_separator() +
"nested" + path::get_separator(),
EXPECT_TRUE(ContainsExactString(Twine("~/foo/nested") + path::get_separator(),
Results));
Count = CommandCompletions::DiskDirectories("~/foo/nes", Results, Resolver);
ASSERT_EQ(1u, Count);
ASSERT_EQ(Count, Results.GetSize());
EXPECT_TRUE(ContainsExactString(Twine("~/foo") + path::get_separator() +
"nested" + path::get_separator(),
EXPECT_TRUE(ContainsExactString(Twine("~/foo/nested") + path::get_separator(),
Results));
// With ~username syntax it should return one match if there is an exact