From 51715fbd96c100e08ad5e0afe78eff474e4caa3f Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Fri, 12 Nov 2021 19:25:37 -0800 Subject: [PATCH] [lld-macho] Fix warning ``` /Users/ksmiley/dev/llvm-project/lld/MachO/Symbols.cpp:43:27: warning: field 'external' will be initialized after field 'weakDefCanBeHidden' [-Wreorder-ctor] weakDef(isWeakDef), external(isExternal), ^ 1 warning generated. ``` Differential Revision: https://reviews.llvm.org/D113823 --- lld/MachO/Symbols.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lld/MachO/Symbols.cpp b/lld/MachO/Symbols.cpp index 7b04d2512f67..ed9b4d6383ad 100644 --- a/lld/MachO/Symbols.cpp +++ b/lld/MachO/Symbols.cpp @@ -40,8 +40,8 @@ Defined::Defined(StringRefZ name, InputFile *file, InputSection *isec, overridesWeakDef(canOverrideWeakDef), privateExtern(isPrivateExtern), includeInSymtab(true), thumb(isThumb), referencedDynamically(isReferencedDynamically), noDeadStrip(noDeadStrip), - weakDef(isWeakDef), external(isExternal), - weakDefCanBeHidden(isWeakDefCanBeHidden) { + weakDefCanBeHidden(isWeakDefCanBeHidden), weakDef(isWeakDef), + external(isExternal) { if (isec) { isec->symbols.push_back(this); // Maintain sorted order.