maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

[SelectionDAGISel] Add back a comment to MergeInputChains handling. NFC 

This comment used to exist, but was lost in a refactor over 10 years
ago, but still seems relevant and improves readability.
This commit is contained in:
Craig Topper 2022-05-05 12:57:17 -07:00
parent 98616cfc02
commit 5140e0d219
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
View File

@ -3269,6 +3269,8 @@ void SelectionDAGISel::SelectCodeCommon(SDNode *NodeToMatch,
assert(RecNo < RecordedNodes.size() && "Invalid EmitMergeInputChains");
ChainNodesMatched.push_back(RecordedNodes[RecNo].first.getNode());
// If the chained node is not the root, we can't fold it if it has
// multiple uses.
// FIXME: What if other value results of the node have uses not matched
// by this pattern?
if (ChainNodesMatched.back() != NodeToMatch &&
@ -3306,6 +3308,8 @@ void SelectionDAGISel::SelectCodeCommon(SDNode *NodeToMatch,
assert(RecNo < RecordedNodes.size() && "Invalid EmitMergeInputChains");
ChainNodesMatched.push_back(RecordedNodes[RecNo].first.getNode());
// If the chained node is not the root, we can't fold it if it has
// multiple uses.
// FIXME: What if other value results of the node have uses not matched
// by this pattern?
if (ChainNodesMatched.back() != NodeToMatch &&