diff --git a/clang/lib/Analysis/RegionStore.cpp b/clang/lib/Analysis/RegionStore.cpp index 6253e6182f4b..883821128af9 100644 --- a/clang/lib/Analysis/RegionStore.cpp +++ b/clang/lib/Analysis/RegionStore.cpp @@ -620,9 +620,21 @@ SVal RegionStoreManager::EvalBinOp(BinaryOperator::Opcode Op, Loc L, NonLoc R) { if (!isa(L)) return UnknownVal(); - const MemRegion* MR = cast(L).getRegion(); + const TypedRegion* TR + = cast(cast(L).getRegion()); + + const ElementRegion* ER = dyn_cast(TR); + + if (!ER) { + // If the region is not element region, create one with index 0. This can + // happen in the following example: + // char *p = foo(); + // p += 3; + // Note that p binds to a TypedViewRegion(SymbolicRegion). + nonloc::ConcreteInt Idx(getBasicVals().getZeroWithPtrWidth(false)); + ER = MRMgr.getElementRegion(Idx, TR); + } - const ElementRegion* ER = cast(MR); SVal Idx = ER->getIndex(); nonloc::ConcreteInt* Base = dyn_cast(&Idx); @@ -632,7 +644,7 @@ SVal RegionStoreManager::EvalBinOp(BinaryOperator::Opcode Op, Loc L, NonLoc R) { if (Base && Offset) { // For now, convert the signedness of offset in case it doesn't match. const llvm::APSInt &I = - getBasicVals().ConvertSignedness(Base->getValue(), Offset->getValue()); + getBasicVals().ConvertSignedness(Base->getValue(), Offset->getValue()); nonloc::ConcreteInt OffsetConverted(I); SVal NewIdx = Base->EvalBinOp(getBasicVals(), Op, OffsetConverted); diff --git a/clang/test/Analysis/ptr-arith.c b/clang/test/Analysis/ptr-arith.c index a8d03eb3d888..7b66b2f8fe35 100644 --- a/clang/test/Analysis/ptr-arith.c +++ b/clang/test/Analysis/ptr-arith.c @@ -5,3 +5,10 @@ void f1() { int *p = a; ++p; } + +char* foo(); + +void f2() { + char *p = foo(); + ++p; +}