maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity

Fix PR 5422: handle lvalue results when evaluating 'based' ptrtoints as part of 

the -Wconversion check.

llvm-svn: 86891
This commit is contained in:
John McCall 2009-11-11 22:52:37 +00:00
parent d708eb6b6a
commit 5055e4cdfd
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
clang/lib/Sema/Sema.cpp
View File

@ -424,9 +424,15 @@ static bool IsSameIntAfterCast(const APValue &value, unsigned TargetWidth) {
return true; return true;
} }
assert(value.isComplexInt()); if (value.isComplexInt()) {
return IsSameIntAfterCast(value.getComplexIntReal(), TargetWidth) && return IsSameIntAfterCast(value.getComplexIntReal(), TargetWidth) &&
IsSameIntAfterCast(value.getComplexIntImag(), TargetWidth); IsSameIntAfterCast(value.getComplexIntImag(), TargetWidth);
}
// This can happen with lossless casts to intptr_t of "based" lvalues.
// Assume it might use arbitrary bits.
assert(value.isLValue());
return false;
} }

6
clang/test/Sema/conversion.c
View File

@ -229,3 +229,9 @@ void test15(char c) {
c = c + 1 + c * 2; c = c + 1 + c * 2;
c = (short) c + 1 + c * 2; // expected-warning {{implicit cast loses integer precision}} c = (short) c + 1 + c * 2; // expected-warning {{implicit cast loses integer precision}}
} }
// PR 5422
extern void *test16_external;
void test16(void) {
int a = (unsigned long) &test16_external; // expected-warning {{implicit cast loses integer precision}}
}